Repository navigation
be: list every query adminer sends in tracy's bar, through dibi's sql panel - #194
Merged
Merged
Conversation
[Medium impact] No established blocking issue remains; the PR appears safe to merge. SummaryAdds a debug-only SQL panel that sends Adminer queries to dibi’s Tracy panel.
No new actionable findings were established. The full PR diff was reviewed because the previous and current commits have different merge bases with the target commit.
|
… panel No ready-made panel sees adminer's queries: it talks to mysqli, pgsql and PDO directly. A patch adds an afterQuery hook to the bundled drivers until upstream has one, and Desktop\QueryLog replays each query into dibi's panel under -debug. dibi is a dev dependency, so a release ships neither.
…it fill the window A SQL command, a select with its filters or an edit is what you are debugging; it was lost among the dozens of queries adminer runs around it. Each is now marked user or app through dibi's Connection column, user ones first. Tracy's 700x500 cap also hid most of the list.
… is dropped once released
…pstan rejects them untyped
landsman
force-pushed
the
be/tracy-sql-panel
branch
from
October 24, 2026 22:56
26aacda to
ba37dee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under
-debug, Tracy's bar now lists every query adminer sends — SQL, time, row count. No ready-made panel can see them, because adminer talks to mysqli, pgsql and PDO directly;patches/adminer-after-query.patchadds anafterQuery()hook to the bundled drivers (MySQLi, PgSQL, SQLite3,PdoDb), andDesktop\QueryLogreplays each query into dibi's panel as anEvent.user, the restapp, through dibi's Connection column (it appears once there are two connections — both lazy, neither connects). User ones come first; the hooks that say so fire before or after the query, so rows are built when the bar renders.Debug::plugins()checks for it.adminer.phpevery time.Debug.phpnote that the bar renders blank; it renders.Checked against a throwaway postgres: a
pg_classselect listed 72 queries / 35.2 ms.make qa,make checkandmake e2e(both drivers) pass.make e2e-packagedfails a few scenarios, a different set each run, and does the same on main.