Skip to content

fe: patch adminer's functionChange(), every nullable boolean's edit form threw on load - #180

Merged
landsman merged 2 commits into
mainfrom
fix/bool-function-change
Oct 20, 2026
Merged

landsman merged 2 commits into
mainfrom
fix/bool-function-change

Conversation

@landsman

Copy link
Copy Markdown
Owner

Closes #171

Adminer renders a boolean as a hidden input plus a checkbox of the same name, so functionChange()'s this.form[name] is a RadioNodeList with no classList, and the initial fire() of a nullable boolean's function select threw on every edit and insert form that has one. The patch takes the checkbox out of the list; it is the change proposed upstream in vrana/adminer#1364, and goes once a release carries it.

Upstream's own pgsql.spec.js gains a test that fails without the fix. Here, the users edit form in shortcuts.feature no longer prints adminer's error from the page-error guard; qa, check and the full e2e pass.

@landsman
landsman merged commit 1e4c05a into main Oct 20, 2026
5 checks passed
@landsman
landsman deleted the fix/bool-function-change branch October 20, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fe: functionChange() throws on a row's edit form, adminer looks its field up by a name two controls share

1 participant