Skip to content

fix: rename 'Delete' to 'Delete Message' in activity history (closes devguard#2116)#780

Merged
timbastin merged 2 commits into
l3montree-dev:mainfrom
arinbalyan:fix/issue-2116-misleading-delete-label
Jun 12, 2026
Merged

fix: rename 'Delete' to 'Delete Message' in activity history (closes devguard#2116)#780
timbastin merged 2 commits into
l3montree-dev:mainfrom
arinbalyan:fix/issue-2116-misleading-delete-label

Conversation

@arinbalyan

Copy link
Copy Markdown
Contributor

Description

Fixes l3montree-dev/devguard#2116

Renames the misleading "Delete" label to "Delete Message" in the event activity history three-dot menu. The previous label implied deleting the VEX rule itself, when it only removes the history entry.

Changes

  • RiskAssessmentFeed.tsx: Changed "Delete" → "Delete Message" in RiskFeedItem dropdown menu item

Checklist

  • Pre-existing lint passes (no new issues introduced)
  • All 17 tests pass
  • No breaking changes
  • Only the relevant file changed

Copilot AI review requested due to automatic review settings June 10, 2026 09:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the risk assessment feed UI copy for the delete action in the item dropdown.

Changes:

  • Renamed the dropdown delete label from “Delete” to “Delete Message”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

>
<DropdownMenuItem onSelect={(e) => e.preventDefault()}>
Delete
Delete Message

@timbastin timbastin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arinbalyan thanks a lot for your contribution! Just a minor change. I am looking forward to merging this PR!

>
<DropdownMenuItem onSelect={(e) => e.preventDefault()}>
Delete
Delete Message

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have this as something like: "Delete Event in History"

Do you mind making that change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Changed it to 'Delete Event in History' and pushed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the naming change or something else ? because the copillot review is a little confusing above.

I have updated the name to "Delete Event in History" if that is what you wanted.

@timbastin timbastin merged commit 4108ce0 into l3montree-dev:main Jun 12, 2026
@timbastin

Copy link
Copy Markdown
Member

Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading "Delete" Label in Activity History for VEX Rule Events

3 participants