fix(wallpaper): fix lock/unlock transition broken by GL thread lifecycle change#11
Merged
Merged
Conversation
kxxoling
commented
Jul 4, 2026
kxxoling
commented
Owner
- Change RECEIVER_NOT_EXPORTED → RECEIVER_EXPORTED: ACTION_USER_PRESENT is sent by a non-system_server process on some OEM ROMs (e.g. ASUS ZenUI) and was silently blocked, so unlock never triggered.
- Keep GL thread alive across visibility changes instead of stop/restart: add a 'rendering' flag so EGL context and textures stay resident, eliminating the template-reload stutter on screen-on.
- Extract updateTransition() from onDrawFrame() and call it even while not rendering, so the lock lerp completes while the screen is off and the first visible frame is already at the correct position.
- Add @volatile to cross-thread transition fields for visibility.
- Add 13 regression tests covering triggerLock/triggerUnlock/updateTransition.
…cle change - Change RECEIVER_NOT_EXPORTED → RECEIVER_EXPORTED: ACTION_USER_PRESENT is sent by a non-system_server process on some OEM ROMs (e.g. ASUS ZenUI) and was silently blocked, so unlock never triggered. - Keep GL thread alive across visibility changes instead of stop/restart: add a 'rendering' flag so EGL context and textures stay resident, eliminating the template-reload stutter on screen-on. - Extract updateTransition() from onDrawFrame() and call it even while not rendering, so the lock lerp completes while the screen is off and the first visible frame is already at the correct position. - Add @volatile to cross-thread transition fields for visibility. - Add 13 regression tests covering triggerLock/triggerUnlock/updateTransition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.