[DB-2161]: Add config properties for DuckDB temp files - #5668
Merged
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
…her configuration options
because less likely to cause operational problems e.g. if user has their system temp space on a smaller or less performant drive than their data. call GetFullPath rather than requiring it to be full path, same as we do for db and index path configuration
…her than ignoring
Deploying eventstore with
|
| Latest commit: |
d219519
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2d495504.eventstore.pages.dev |
| Branch Preview URL: | https://sakno-duckdb-tmp-dir.eventstore.pages.dev |
There was a problem hiding this comment.
Pull request overview
Adds configuration for DuckDB’s temporary file directory and maximum temp disk usage, wires those settings through to the DuckDB connection pool, and documents/validates the new options.
Changes:
- Introduces
SqlEngineTempDirectoryandSqlEngineTempDirectorySizeLimitoptions and passes them into DuckDB connection configuration. - Adds startup cleanup of leftover DuckDB
*.tmpartifacts in the configured temp directory. - Extends configuration validation + adds unit tests and documentation for the new settings.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/KurrentDB.Core/TransactionLog/Chunks/TFChunkDbConfig.cs | Adds init-only properties to carry DuckDB temp directory settings into core DB config. |
| src/KurrentDB.Core/DuckDB/DuckDBConnectionPoolLifetime.cs | Applies DuckDB temp settings and attempts startup cleanup of stale temp artifacts. |
| src/KurrentDB.Core/Configuration/ClusterVNodeOptionsValidator.cs | Validates new options (non-negative size limit, path constraints, distinct directories). |
| src/KurrentDB.Core/Configuration/ClusterVNodeOptions.cs | Defines new configuration options and help text. |
| src/KurrentDB.Core/ClusterVNode.cs | Plumbs new options into TFChunkDbConfig creation. |
| src/KurrentDB.Core.XUnit.Tests/DuckDB/DuckDBConnectionPoolLifetimeTests.cs | Adds tests verifying startup cleanup behavior for default and configured temp directories. |
| src/KurrentDB.Core.XUnit.Tests/Configuration/ClusterVNodeOptionsValidatorTests.cs | Adds tests for new validation rules. |
| docs/server/configuration/db-config.md | Documents the new CLI/YAML/env settings and defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timothycoleman
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed: Added configuration properties needed to adjust location and size limit of the temp files produced by embedded DuckDB