Add update_Q_A to MEX interface#6
Open
alexandre-faye wants to merge 3 commits into
Open
Conversation
Add the update_Q_A method to the MATLAB MEX interface
Turns out, my previous proposal behaved badly when zeros were introduced in (or removed from) the matrices. This fixes it.
Replacing the remaining tabs with 4x space
Collaborator
|
Thanks a lot for the contribution! |
Author
|
I should precise something, if you still plan on doing the review: I implemented the MATLAB interface such that it takes whole matrices (either dense or sparse), whereas the C/C++ interface needs the upper diagonal coefficients of Q. I feel like it fits the MATLAB style more, but it is sort of inconsistent with the other interfaces. For reference, the MATLAB OSQP interface requires the upper diagonal coeffs, but their update function is a bit different (in the lines of In the end I also did this because it felt more fit to my use-case, but I'm open to doing it differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
update_Q_Amethod to the MATLAB MEX interface since I use it a lot.This code works in my limited testing for my limited use-case.