feat(adminqos): add memory plugin config support - #215
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe configuration API adds optional memory fragmentation, THP, and host-watermark settings. Generated deepcopy methods copy these settings through nested configuration objects. 配置 API 新增可选的内存碎片整理、THP 和主机水位设置。生成的深拷贝方法会复制这些嵌套配置对象。 ChangesMemory configuration API / 内存配置 API
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR adds configuration API types, generated deepcopy support, and CRD definitions; no actionable merge-blocking risk remains based on the supplied evidence. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/apis/config/v1alpha1/adminqos.go`:
- Around line 417-424: Preserve the existing v1alpha1 exported fields and JSON
tags in FragMemConfig and HostWatermarkConfig as deprecated compatibility
fields, while retaining the renamed fields only if needed for the new API shape.
Ensure old manifest keys continue to deserialize and remain represented in
generated CRDs; do not replace the prior fields or wire keys without adding an
explicit API-version conversion and migration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: bdf5314b-8204-4409-8ed1-156f82d2dbe0
⛔ Files ignored due to path filters (1)
config/crd/bases/config.katalyst.kubewharf.io_adminqosconfigurations.yamlis excluded by!config/crd/bases/**
📒 Files selected for processing (2)
pkg/apis/config/v1alpha1/adminqos.gopkg/apis/config/v1alpha1/zz_generated.deepcopy.go
🚧 Files skipped from review as they are similar to previous changes (1)
- pkg/apis/config/v1alpha1/zz_generated.deepcopy.go
add MemoryPluginConfig field to QRMPluginConfig, define new FragMemConfig and HostWatermarkConfig types, and add their autogenerated deepcopy implementations refactor(adminqos): rename fragmem and hostwatermark configs and generate crds refactor: align hostwaterconfig comment naming refactor: fix hostwatermarkconfig comments
a300231 to
6b16cfc
Compare
add MemoryPluginConfig field to QRMPluginConfig, define new FragMemConfig and HostWatermarkConfig types, and add their autogenerated deepcopy implementations
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
English
API surface
MemoryPluginConfigtoQRMPluginConfig.MemoryPluginConfig,FragMemConfig, andHostWatermarkConfig.Compatibility
Code generation
QRMPluginConfigdeepcopy handling forMemoryPluginConfig.简体中文
API surface
QRMPluginConfig添加可选的MemoryPluginConfig。MemoryPluginConfig、FragMemConfig和HostWatermarkConfig。兼容性
代码生成
QRMPluginConfig对MemoryPluginConfig的 deepcopy 处理。