Skip to content

fix: add concurrency with cancel-in-progress to PR-triggered workflows - #7201

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-7200
Oct 2, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-7200

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #7200

Adds a concurrency block with cancel-in-progress: true to PR-triggered workflows so superseded runs are cancelled when new commits are pushed, saving CI runner time.

— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 2, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2026
@kubestellar-prow

Copy link
Copy Markdown

Hi @hivecommons-hive[bot]. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify

netlify Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kubestellar-docs ready!

Name Link
🔨 Latest commit 2bb5ca9
🔍 Latest deploy log https://app.netlify.com/projects/kubestellar-docs/deploys/6abfad6ee1666e0008793a42
😎 Deploy Preview https://deploy-preview-7201--kubestellar-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correctly applies the concurrency block from #7200 to all 7 listed workflows, and for the 5 plain pull_request/push gates it matches the vitest.yml precedent and is safe. Two of the files have trigger types the issue's one-size recommendation didn't account for:

1. pr-verifier.yml — cross-PR cancellation (should be fixed before merge)

.github/workflows/pr-verifier.yml:18-24: this workflow triggers on pull_request_target, and for that event github.ref resolves to the base branch ref (refs/heads/main), not a per-PR ref. Every PR's verifier run therefore lands in the single group PR Verifier-refs/heads/main, and with cancel-in-progress: true any PR being opened/edited/synced cancels the in-flight verifier run of an unrelated PR. On a repo with this queue volume, PRs will routinely show a cancelled PR-Verifier check through no fault of their own. Fix is one line:

group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}

2. fuzz-mdx.yml — schedule/dispatch share a group (low, optional)

.github/workflows/fuzz-mdx.yml:28-30: this workflow also runs on schedule and workflow_dispatch, both of which resolve github.ref to refs/heads/main, so a manual dispatch can cancel the weekly scheduled fuzz run (or vice versa). #7200 explicitly called cancel-in-progress undesirable for scheduled runs. Rare in practice; the same || github.ref pattern plus github.event_name in the group would isolate them if you care.

The remaining 5 files (typecheck.yml, markdownlint-cli2.yml, check-internal-links.yml, cluster-objects-lint.yml, dashboard-lint.yml) are pull_request (+ some push: main) only — per-PR merge refs, stateless gates, correct as written. Note the defect in item 1 was inherited from the exact block #7200 recommended; the diff faithfully implements the issue.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 926ea77 into main Oct 2, 2026
17 of 20 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-7200 branch October 2, 2026 13:18
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd copilot dco-signoff: yes Indicates the PR's author has signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. yaml

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ci-maintainer] add concurrency+cancel-in-progress to PR-triggered workflows missing it

0 participants