Repository navigation
fix: add concurrency with cancel-in-progress to PR-triggered workflows - #7201
Conversation
Signed-off-by: scanner <scanner@hive.kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @hivecommons-hive[bot]. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubestellar-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
This correctly applies the concurrency block from #7200 to all 7 listed workflows, and for the 5 plain pull_request/push gates it matches the vitest.yml precedent and is safe. Two of the files have trigger types the issue's one-size recommendation didn't account for:
1. pr-verifier.yml — cross-PR cancellation (should be fixed before merge)
.github/workflows/pr-verifier.yml:18-24: this workflow triggers on pull_request_target, and for that event github.ref resolves to the base branch ref (refs/heads/main), not a per-PR ref. Every PR's verifier run therefore lands in the single group PR Verifier-refs/heads/main, and with cancel-in-progress: true any PR being opened/edited/synced cancels the in-flight verifier run of an unrelated PR. On a repo with this queue volume, PRs will routinely show a cancelled PR-Verifier check through no fault of their own. Fix is one line:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}2. fuzz-mdx.yml — schedule/dispatch share a group (low, optional)
.github/workflows/fuzz-mdx.yml:28-30: this workflow also runs on schedule and workflow_dispatch, both of which resolve github.ref to refs/heads/main, so a manual dispatch can cancel the weekly scheduled fuzz run (or vice versa). #7200 explicitly called cancel-in-progress undesirable for scheduled runs. Rare in practice; the same || github.ref pattern plus github.event_name in the group would isolate them if you care.
The remaining 5 files (typecheck.yml, markdownlint-cli2.yml, check-internal-links.yml, cluster-objects-lint.yml, dashboard-lint.yml) are pull_request (+ some push: main) only — per-PR merge refs, stateless gates, correct as written. Note the defect in item 1 was inherited from the exact block #7200 recommended; the diff faithfully implements the issue.
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
Closes #7200
Adds a
concurrencyblock withcancel-in-progress: trueto PR-triggered workflows so superseded runs are cancelled when new commits are pushed, saving CI runner time.— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88