Skip to content

[quality] exclude three.js animation components from coverage collection - #6816

Open
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
quality/exclude-animations-from-coverage
Open

[quality] exclude three.js animation components from coverage collection#6816
kubestellar-hive[bot] wants to merge 1 commit into
mainfrom
quality/exclude-animations-from-coverage

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds src/components/animations/**/*.tsx to vitest.config.ts coverage.exclude. That subtree is 1,233 LOC of three.js scene wiring across 10 components (NetworkGlobe 423 LOC alone) that cannot be meaningfully asserted in JSDOM: no WebGL context, no accurate rAF semantics, no scene-graph introspection without pulling in a headless-GL stack the docs site does not need at test time.

Currently those 1,233 uncovered lines drag the overall vitest number down with no realistic path to a passing test.

The pattern is intentionally narrow:

  • .tsx only — src/components/animations/globe/colors.ts (pure export, already covered by src/__tests__/data-exports.test.ts) stays in coverage.
  • Scoped to animations/ — no other component subtree is touched.

What this is / isn't

Context

This is step 3 of the 4-step remediation plan I filed in #6815, which itself explains why the src/lib/ top-10 in #6703 was a red herring — sanitizeHtml.ts alone has 52 tests across 4 files. The real coverage deficit is in src/components/ (Navbar 1148 LOC, DocsNavbar 1076 LOC, DocsSidebar 633 LOC, etc.), and steps 1 (refactor pure logic out of navbars) + 2 (render-smoke tests for master-page sections) need human contributors.

Refs #6815
Refs #6703
Refs #6720


Filed by quality agent (ACMM L4/L6 — full mode)

— hive: agent=quality backend=copilot model=claude-opus-4.7

Adds 'src/components/animations/**/*.tsx' to vitest coverage.exclude.
Those files are three.js scene wiring (NetworkGlobe 423 LOC, Cluster
163 LOC, LogoElement 115 LOC, DataPacket 105 LOC, StarField 104 LOC,
GridLines 100 LOC, GlobeAnimation 94 LOC, GlowingSphere 61 LOC,
GlobeLoader 52 LOC, Loader 16 LOC — 1,233 LOC total) that cannot be
meaningfully asserted in JSDOM: no WebGL context, no accurate
requestAnimationFrame semantics, no way to inspect the scene graph
without pulling in a headless-GL stack the docs site does not need
at test time.

Currently these 1,233 uncovered lines drag the overall vitest
coverage number down without a realistic path to a passing test.
The exclusion pattern is deliberately narrow:

  * .tsx only — leaves .ts files in coverage collection so
    src/components/animations/globe/colors.ts (pure export, already
    tested by src/__tests__/data-exports.test.ts) still counts.
  * scoped to animations/ — no other component subtree is touched.

This is step 3 of the four-step remediation plan in #6815 (which
also explains why #6703's src/lib/ top-10 was a red herring: sanitizeHtml
alone has 52 tests, and the real coverage gap is in src/components/).
Steps 1 (refactor pure logic out of Navbar/DocsNavbar) and 2 (smoke
tests for master-page sections) require human contributors; step 4
(raise thresholds — #6720) is unblocked once the overall number moves.

No test change, no production code change, no workflow change.

Refs #6815
Refs #6703
Refs #6720

Signed-off-by: kubestellar-hive[bot] <223556219+Copilot@users.noreply.github.com>
@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human sign-off on the direction, not on the code.

This PR's only tracked rationale is #6815, which the hive filed itself — issue #6815 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117).

The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the approved-direction label — and remove the hold label here.

@kubestellar-hive kubestellar-hive Bot added the hold label Sep 8, 2026
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Sep 8, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kproche for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Sep 8, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellar-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 4eb4164
🔍 Latest deploy log https://app.netlify.com/projects/kubestellar-docs/deploys/6aa072e7e77ddc0008ac3faf

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2026
@kubestellar-prow

Copy link
Copy Markdown

Hi @kubestellar-hive[bot]. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. hold needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant