🌱 [scanner] refactor: extract validation handlers to pkg/api/handlers/internal/httputil (epic #23685 phase 1)

[hivecommons-hive]

Refs #23685 (epic/multi-phase tracker — this lands one phase-1 domain slice; remaining domains follow in later PRs)

Summary

Phase-1 slice for the internal/httputil row of the epic plan: the last cross-cutting input validators leave the flat pkg/api/handlers root package. Mechanical and behavior-preserving, modeled on #23684 and #23688.

File	Action
validate_helpers.go	git mv → internal/httputil/validate_helpers.go. Validators exported so domain subpackages can reuse them: ValidateDNSLabel, ValidateDNSSubdomain, ValidateClusterName, ValidateRoleName, ValidateEnum. Bodies unchanged.
validation.go (cron + version validators)	Moved to new internal/httputil/validation.go as IsValidCronSchedule, IsValidK8sVersion, K8sVersionPattern. Bodies unchanged.
validation.go (root)	Now a thin alias file keeping MaxK8sNameLen, IsValidK8sName, IsValidK8sVersion — the symbols pkg/api/handlers/mcp calls. The now-dead unexported duplicates (validateK8sName, validateClusterAndNamespace, isValidCronSchedule, k8sNamePattern) are dropped; httputil.ValidateK8sName / ValidateClusterAndNamespace (landed in #23684) are the single implementation.

Tests moved with the code

• validate_helpers_test.go → internal/httputil/validate_helpers_test.go via git mv (package + validator names updated only).
• Cron / version / regex tests moved from root validation_test.go → internal/httputil/validation_test.go.
• Root validation_test.go keeps the tests for the aliases that remain (IsValidK8sName, MaxK8sNameLen, plus a short delegation check for IsValidK8sVersion).
• Added two table cases (too long) for ValidateClusterName / ValidateRoleName so internal/httputil stays at 100%.

Verification

• go build ./... — passes.
• go test ./pkg/api/... -count=1 — all packages pass.
• Coverage: pkg/api/handlers 93.8% (well above the 66.5% ratchet floor), pkg/api/handlers/internal/httputil 100.0%, pkg/api/handlers/mcp unchanged at 68.1%.

No route registration, exported HTTP behavior, frontend, or Netlify changes.

— hive: agent=scanner backend=copilot model=claude-fable-5 copilot=1.0.88

[netlify]

✅ Deploy Preview for kubestellarconsole canceled.

Name	Link
🔨 Latest commit	e098e63
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/6ab53224c66ef20008e29e1b

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

👋 Hey @hivecommons-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

• Claude Code (Opus 4.5 / 4.6) — recommended
• GitHub Copilot
• Cursor
• Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

---

This is an automated message.

[hivecommons-hive]

Read this against main, not just the diff — looks correct to me.

Verified specifics:

• The unexported identifiers this PR deletes from the root package (validateK8sName, validateClusterAndNamespace, isValidCronSchedule, cronFieldPattern, k8sNamePattern, and the validateDNSLabel family) have no callers anywhere on main outside the moved files themselves — code search finds them only in pkg/api/handlers/validation.go/validate_helpers.go and their tests. So dropping the duplicates and exporting the httputil versions cannot break any handler.
• Function bodies in internal/httputil/validate_helpers.go and validation.go are byte-identical to what left the root package (rename-only, as the body claims); IsValidK8sVersion in httputil correctly reuses the already-moved MaxK8sNameLen.
• The root aliases kept in pkg/api/handlers/validation.go (MaxK8sNameLen, IsValidK8sName, IsValidK8sVersion) cover the symbols pkg/api/handlers/mcp still uses.
• All checks green on head e098e63, including go test ./... and the coverage gates, consistent with the body's 93.8%/100% numbers.

Behavior-preserving as advertised; a maintainer can merge this on a quick skim.

— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.88

[github-actions]

Thank you for your contribution! Your PR has been merged.

Check out what's new:

• KubeStellar Console — Live multi-cluster dashboard
• Marketplace — Community extensions
• Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

[github-actions]

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 53fc94a56b31420ed35ae7f603375e2c5202971b.

[github-actions]

✅ Post-Merge Verification: passed

Commit: 53fc94a56b31420ed35ae7f603375e2c5202971b
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/36018752504