Skip to content

[operations] Document mission-content-validation.yml runbooks/** false-green gap (4th exception, same class as #3157/#3235/#3255/#3268) - #3303

Merged
hivecommons-hive[bot] merged 2 commits into
masterfrom
operations/document-mission-content-validation-gap
Sep 11, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
masterfrom
operations/document-mission-content-validation-gap

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary

mission-content-validation.yml has the same runbooks/** false-green pattern already documented in docs/slo.md and runbooks/incident-response-unsafe-mission-merge.md for mission-safety-scan.yml, validate-schema.yml, and kb-quality-enforcement.yml. This was confirmed and filed as #3292 (closed not-planned — fixing it needs workflows permission this contribution's credentials do not have), but the SLO doc and incident-response runbook were never updated to include it as a fourth known exception, unlike the other three.

Confirmed gap (docs-only PR, no workflow/code changes)

.github/workflows/mission-content-validation.yml's on.pull_request.paths trigger includes runbooks/**/*.json/*.yaml/*.yml, but neither validation step's git diff pathspec ever selects a runbooks/** file:

  • "Validate mission quality" — scoped to fixes/cncf-install/install-*.{json,yaml,yml} only
  • "Validate mission content" — scoped to fixes/**/*.{json,yaml,yml} only

A runbooks/**-only PR resolves both to an empty file list, prints "No install missions changed"/"No solution files changed", and exit 0 — green, having validated nothing. Confirmed via direct inspection of the workflow file (both pathspecs omit runbooks/** despite the trigger watching it).

Changes

Scope

Documentation only — no changes to .github/workflows/*.yml, alert thresholds, or SLOs. Does not weaken any existing check; adds detection/recovery guidance for a confirmed, currently-unmitigated gap.

Refs: #3292, #3255, #3268, #3235, #3157


Filed under the operations role. Not to be merged by the filer.

— hive: agent=operations backend=copilot model=claude-sonnet-4-6

… false-green gap

mission-content-validation.yml has the same false-green pattern already
documented for mission-safety-scan.yml, validate-schema.yml, and
kb-quality-enforcement.yml: its on.pull_request.paths trigger watches
runbooks/**/*.json|yaml|yml, but neither of its two validation steps'
git diff pathspecs ever selects a runbooks/** file, so a runbooks/**-only
PR reports green having validated nothing (confirmed by inspecting the
workflow file).

This gap was confirmed and filed as #3292, closed not-planned (fixing it
needs workflows permission this contribution's credentials do not have),
but docs/slo.md and runbooks/incident-response-unsafe-mission-merge.md
were never updated to include it alongside the other three tracked
exceptions. This documents the fourth exception, adds detection guidance,
and corrects two stale 'tracked in a separate open issue' references for
#3268/#3235-class issues that have since closed not-planned.

No code, workflow, or SLO/alert threshold changes.

Signed-off-by: kubestellar-hive <hive-operations@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human sign-off on the direction, not on the code.

This PR's only tracked rationale is #3292, which the hive filed itself — issue #3292 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117).

The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the approved-direction label — and remove the hold label here.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Sep 10, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2026
@clubanderson clubanderson removed the hold label Sep 11, 2026
@clubanderson

Copy link
Copy Markdown
Member

Direction acknowledged by hub admin (approved-direction added on #3292); releasing the #5117 hold. This hive runs at ACMM L6 and may act on its own findings.

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

🛑 Fix loop escalated — human attention needed

This PR has stayed red on the same commit through 6 automated fix re-dispatches with no new commit pushed (1 distinct red head seen). The hive has stopped dispatching further automated fixes for it.

Failing checks: Fuzz JavaScript parsers

Raw failure evidence (from check-run annotations):

Fuzz JavaScript parsers: Process completed with exit code 1.
Fuzz JavaScript parsers: Error: Test timed out in 5000ms.

Remove the needs-human label after addressing the root cause to return the PR to the automated fix lane.

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2026
…tion-gap

Signed-off-by: kubestellar-hive[bot] <223556219+Copilot@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit a5d1d37 into master Sep 11, 2026
8 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the operations/document-mission-content-validation-gap branch September 11, 2026 20:28
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. needs-human size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants