[operations] Include runbooks/ in Validate Mission Schema --all sweep

[hivecommons-hive]

Summary

Closes the scheduled/push half of the false-green gap tracked in #3255: scripts/validate-schema.mjs's --all mode (used by validate-schema.yml's push/schedule/dispatch runs) only ever called discoverMissionFiles('fixes'), so the 10 runbooks/*.json mission files had zero automated schema-validation coverage on the weekly cadence sweep — despite using the same kc-mission-v1 schema (see runbooks/README.md).

Changes

• scripts/validate-schema.mjs: added ALL_MODE_DIRS = ['fixes', 'runbooks']; --all mode now scans both, skipping any directory that doesn't exist so a checkout without a runbooks/ directory doesn't crash.
• scripts/__tests__/validate-schema-cli-discover.test.mjs: added tests for runbooks/ discovery and the missing-directory case (31/31 tests pass).
• docs/slo.md: updated the "third known exception" note to reflect that the --all-mode side of the gap is now fixed.

Verified against real repo data:

$ node scripts/validate-schema.mjs --all
...
✅ runbooks/certificate-rotation.json: Valid kc-mission-v1
✅ runbooks/cluster-upgrade.json: Valid kc-mission-v1
... (10/10 runbooks files now included)
{"event":"schema-validation-summary","level":"info","trigger":"all","total":1679,...}
✅ All files passed schema validation.

(Previously total only counted fixes/** files; the 10 runbooks/*.json files were never discovered.)

Not included — needs workflows permission

The other half of #3255 — validate-schema.yml's PR-mode git diff pathspec only matching fixes/**, so a runbooks/**-only PR resolves to an empty file list and the validation step is skipped (job still reports green) — is not in this PR. A branch containing only that one-line pathspec addition was rejected by GitHub:

! [remote rejected] ... (refusing to allow a GitHub App to create or update workflow
`.github/workflows/validate-schema.yml` without `workflows` permission)

The verified, ready-to-apply diff:

--- a/.github/workflows/validate-schema.yml
+++ b/.github/workflows/validate-schema.yml
@@ -34,7 +34,7 @@ jobs:
         id: changed
         if: github.event_name == 'pull_request'
         run: |
-          FILES=$(git diff --name-only --diff-filter=ACMR ${{ github.event.pull_request.base.sha }} ${{ github.sha }} -- 'fixes/**/*.json' 'fixes/**/*.yaml' 'fixes/**/*.yml' | tr '\n' ' ')
+          FILES=$(git diff --name-only --diff-filter=ACMR ${{ github.event.pull_request.base.sha }} ${{ github.sha }} -- 'fixes/**/*.json' 'fixes/**/*.yaml' 'fixes/**/*.yml' 'runbooks/**/*.json' 'runbooks/**/*.yaml' 'runbooks/**/*.yml' | tr '\n' ' ')
           echo "files=$FILES" >> $GITHUB_OUTPUT
       - name: Validate schema (PR — changed files only)

A maintainer with the workflows App permission can apply this directly. #3255 stays open until it lands.

Ref: #3255

— hive: agent=operations backend=copilot model=claude-sonnet-4-6

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hivecommons-hive]

Important

Held for human sign-off on the direction, not on the code.

This PR's only tracked rationale is #3255, which the hive filed itself — issue #3255 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117).

The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the approved-direction label — and remove the hold label here.

[clubanderson]

Direction acknowledged by hub admin (approved-direction added on #3255); releasing the #5117 hold. This hive runs at ACMM L6 and may act on its own findings.

[github-actions]

Thank you for your contribution! Your PR has been merged.

Check out what's new:

• KubeStellar Console — Live multi-cluster dashboard
• Marketplace — Community extensions
• Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey