Conversation
| QUARKUS_PLATFORM_version=3.33.3 | ||
| QUARKUS_VERSION=3.33.3 | ||
| QUARKUS_PLATFORM_version=3.33.2.SP2-redhat-00002 | ||
| QUARKUS_VERSION=3.33.2.redhat-00008 |
There was a problem hiding this comment.
will be adjusted once we have a proof of this working
|
So builder image for example built well: Looking into the test failures that follow |
|
Ok so test needs to be adjusted: fyi @jakubschwan |
|
Adjusted tests, applied new lables ( some are still missing, working on that ), adjusted |
|
Still couple of fixes needed, will santize here and port to |
|
Okay, just some instabilities left and operator e2e. Working on those |
|
Comparing to https://github.com/kubesmarts/kie-tools/pull/451/changes#diff-0f93e9e480131c2502d82d564b801a60fee9d430632d0bd490c843805fb7fabb we still need to check some workflow plugin e2e. Working on it. |
wmedvede
left a comment
There was a problem hiding this comment.
I added some minor comments that I think can be worth to take a second look at.
| Scenario: Verify if the swf and quarkus files are under /home/kogito/.m2/repository | ||
| When container is started with command bash | ||
| Then file /home/kogito/.m2/repository/io/quarkus/platform/quarkus-bom should exist and be a directory | ||
| Then file /home/kogito/.m2/repository/com/redhat/quarkus/platform/quarkus-bom should exist and be a directory |
There was a problem hiding this comment.
So from now, this will only work wuen using the RH quarkus platform?
I'm confused with this line here https://github.com/kubesmarts/kie-tools/pull/466/changes#diff-70f308b794edcd370a6aaadeb47dfaca08e14bb5e2c6c3b7d864fddb97abf3c8L38
That says:
# Defines the value of used quarkus platform. For CI checks to work it needs to remain on community value
# otherwise the build of container images is going to fail since "com.redhat.quarkus.platform" is only
# available in "maven.repository.redhat.com"
KOGITO_IMAGES_CEKIT_MODULES__quarkusGroupId=io.quarkus.platform
KOGITO_IMAGES_CEKIT_MODULES__quarkusGroupId=com.redhat.quarkus.platform
There was a problem hiding this comment.
That needs updating, but yes we want to test against productized Quarkus
There was a problem hiding this comment.
Not sure how this will be, I mean, are you also going to force kogito-runtines and kogito-apps to work with productized Quarkus? Because AFAIK, we need all the stack aligned with the same Quarkus version.
| if [[ -n "${QUARKUS_VERSION}" && "${QUARKUS_VERSION}" != \#\#\#* ]]; then | ||
| quarkus_version="${QUARKUS_VERSION}" | ||
| else | ||
| quarkus_version="${QUARKUS_PLATFORM_VERSION}" |
There was a problem hiding this comment.
this fallback to QUARKUS_PLATFORM_VERSION I'm not sure if good 🤔
Since below, it's being used e.g. to complete the version when adding a quarkus extension when the version is missing, see:
we have basically:
# If the version is missing, append the default version based on the groupId
if [ -z "$version" ]; then
if [[ "$group_id" == "io.quarkus" ]]; then
extension="${group_id}:${artifact_id}:${quarkus_version}"
elif [[ "$group_id" == *"kie"* || "$group_id" == *"kogito"* || "$artifact_id" == *"kogito"* || "$artifact_id" == *"sonataflow"* ]]; then
extension="${group_id}:${artifact_id}:${kogito_version}"
fi
fi
but, an io.quarkus extension will never have a QUARKUS_PLATFORM_VERSION like 3.33.2.SP2-redhat-00002 I think. Since that numer is only for the platform, but not for the inner extensions.
There was a problem hiding this comment.
Yes, correct. Will double check then, I was not aware it is doing this
There was a problem hiding this comment.
In general the fallback is here in case the QUARKUS_PLATFORM_VERSION=QUARKUS_VERSION we do not need to have 2 variables, however I would vote to always have them set.
| @@ -166,10 +169,20 @@ def update_quarkus_platform_version(quarkus_platform_version): | |||
| Update quarkus_platform_version version into images/modules | |||
| :param quarkus_platform_version: quarkus version to set | |||
There was a problem hiding this comment.
| :param quarkus_platform_version: quarkus version to set | |
| :param quarkus_platform_version: quarkus platform version to set |
| parser.add_argument('--source-folder', dest='source_folder') | ||
| parser.add_argument('--quarkus-groupid', dest='quarkus_groupid', help='Sets the image Quarkus groupId') | ||
| parser.add_argument('--quarkus-version', dest='quarkus_version', help='Sets the image Quarkus Version') | ||
| parser.add_argument('--quarkus-version', dest='quarkus_version', help='Sets the image Quarkus Platform Version') |
There was a problem hiding this comment.
| parser.add_argument('--quarkus-version', dest='quarkus_version', help='Sets the image Quarkus Platform Version') | |
| parser.add_argument('--quarkus-version', dest='quarkus_version', help='Sets the image Quarkus Version') |
https://redhat.atlassian.net/browse/SRVLOGIC-1158
Cherry-picks 465 to
mainrun standard e2e
run operator e2e