Fix WASM use-after-free by capturing pointers by value - #62
Open
Man1ac-1773 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #53
Description
On WebAssembly,
QFileDialog::getOpenFileContentreturns immediately, executing the provided callback asynchronously.In
connector.cppandauxconnector.cpp, the lambdas passed to this function capture pointer parameters by reference (&open,&gls,&c,&pd,&pm). By the time the async callback is invoked, the enclosing stack frame has been destroyed, resulting in dangling references and undefined behavior.This patch fixes the issue by capturing these pointers by value. Since the pointed-to objects are long-lived Qt UI models that outlive the file dialog, capturing them by value is both safe and correct.