Skip to content

Fix TLE XML corruption and prevent Aris crash during proof evaluation - #50

Open
jaybutani1793 wants to merge 2 commits into
kovzol:masterfrom
jaybutani1793:fix-issue-25-tle-hang
Open

Fix TLE XML corruption and prevent Aris crash during proof evaluation#50
jaybutani1793 wants to merge 2 commits into
kovzol:masterfrom
jaybutani1793:fix-issue-25-tle-hang

Conversation

@jaybutani1793

Copy link
Copy Markdown
Contributor

Problem

The provided TLE file contains corrupted XML entries (notably in lines n=5 and n=30) due to incorrect encoding and invalid characters (e.g., ÿ).
Although the file loads in the web version (with console warnings), GNU Aris (Qt version) crashes or hangs when evaluating the proof.

Root Cause

  • Invalid XML content in r attributes (e.g., r="dÿ")
  • Corrupted characters introduced during file saving
  • Missing validation in proof evaluation:
    • Invalid references
    • Self-references (e.g., l="8")
    • References to non-existent steps
  • These lead to invalid memory access, causing segmentation faults

#1. XML Fixes

  • Removed invalid characters (ÿ)
  • Fixed malformed attributes
  • Ensured proper UTF-8 encoding

2. Reference Fixes

  • Removed references to non-existent entries
  • Eliminated self-referencing steps
  • Fixed invalid dependencies

#3. Stability Improvements

  • Cleaned proof structure to prevent:
    • Infinite loops
    • Invalid pointer access

Testing

  • ✅ File loads correctly in web version (no console errors)
  • ✅ File loads in aris-qt.exe
  • ✅ Proof evaluation runs without crash or hang
  • ✅ No segmentation fault observed

@jaybutani1793
jaybutani1793 marked this pull request as draft April 5, 2026 17:31
@jaybutani1793
jaybutani1793 marked this pull request as ready for review April 5, 2026 17:32
@kovzol

kovzol commented Apr 6, 2026

Copy link
Copy Markdown
Owner

Thanks, I'll check it soon.

@faresbakhit

Copy link
Copy Markdown
Contributor

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants