Repository navigation
Conversation
…o ratelimit) bch2_recovery_pass_set_no_ratelimit() wrote false, so the flag never reached the superblock. Fixed by bcachefs-tools "passes: bch2_recovery_pass_set_no_ratelimit() never sets the flag".
…uested pass recovery_passes_exclude was masked with a pass number, so excluding scan_for_btree_nodes didn't stop it. Fixed by bcachefs-tools "passes: recovery_passes_exclude is masked with a pass number".
…d folios isn't counted twice bch2_mark_pagecache_reserved() marked nothing, so i_blocks grew a second time. Fixed by bcachefs-tools "fallocate: bch2_mark_pagecache_reserved() marks nothing".
…roup's usage once bch2_quota_transfer() counted the destination's usage twice and refused a chgrp that fit. Fixed by bcachefs-tools "quota: a transfer's limit check counts the destination's usage twice".
… quota usage Deleting a file in a snapshot hit a BUG_ON in the quota code: snapshot inodes were charged at runtime but never counted. Fixed by bcachefs-tools "quota: snapshot inodes are charged at runtime but never counted".
…rite doesn't hang umount The EINVAL return leaked a c->writes ref, and umount waited for it forever. Fixed by bcachefs-tools "sysfs: a bad logged_op_fail_next write leaks c->writes, then umount hangs".
…e target moves its data A label change queued only a pending scan, which never looked at the device's data. Fixed by bcachefs-tools "opts: a device label change never rescans the device's data".
…s while a metadata scan is pending The btree ptr opts check read the cookie at the node key's inode field, so fsck reported every ptr. Fixed by bcachefs-tools "reconcile: a btree ptr's opt check reads the inode cookie".
…a disk reservation The reflink_p update committed without a disk reservation and warned under BCACHEFS_DEBUG. Fixed by bcachefs-tools "ioctl: set_reflink_p_may_update_opts commits without a reservation".
…e pending scan cookie The pending scan cookie was deleted in the scan phase, so stopping the pass before its pending phases lost the work. Fixed by bcachefs-tools "reconcile: the pending scan cookie is deleted before the pending phases run".
…ica with the wrong seq Btree node scrub checked only checksums and called a stale replica good. Fixed by bcachefs-tools "btree node scrub: a stale or torn replica passes".
Owner
|
Applied to master (through bb50556), all eleven. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for koverstreet/bcachefs-tools#1125, one commit per fix, each in its area's existing file. Each fails on testing 9dbd7f860 and passes with its fix.
The quota tests are in single_device.ktest because quota.ktest doesn't start: since 992232f, require-git clones linuxquota into $ktest_deps_dir, but require-make still looks for it next to the test file.