Skip to content

rust: remove PhantomData from TransAttempt - #1112

Open
krakow10 wants to merge 1 commit into
koverstreet:masterfrom
krakow10:unnecessary-pd
Open

krakow10 wants to merge 1 commit into
koverstreet:masterfrom
krakow10:unnecessary-pd

Conversation

@krakow10

@krakow10 krakow10 commented Oct 6, 2026

Copy link
Copy Markdown

I was browsing and noticed this. I'm assuming the PhantomData is leftover from an earlier design iteration when the trans field was a pointer.

@koverstreet
koverstreet force-pushed the rust branch 2 times, most recently from dbf4676 to 951b6f4 Compare October 7, 2026 13:26
@koverstreet
koverstreet force-pushed the rust branch 2 times, most recently from 862f117 to 0d952ff Compare October 8, 2026 09:42
@krakow10
krakow10 force-pushed the unnecessary-pd branch 2 times, most recently from 166459b to c15aba4 Compare October 8, 2026 19:38
The `trans` field already captures the 'a lifetime.
@krakow10
krakow10 changed the base branch from rust to master October 8, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant