[AUTOMATION] fix: optimize internal/run connectable credential retry scan#262
Open
michiosw wants to merge 1 commit into
Open
[AUTOMATION] fix: optimize internal/run connectable credential retry scan#262michiosw wants to merge 1 commit into
michiosw wants to merge 1 commit into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Greptile SummaryThis PR streamlines hosted credential retry collection during run startup. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(run): avoid rescanning disconnected ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This optimizes internal/run credential resolution by collecting disconnected entries during the first pass.
Before this, resolveCredentials walked every entry once, then scanned the failure map again to rebuild the disconnected subset for hosted connect retries.
Now the first pass is the canonical path:
Why
This gives kontext-cli a cheaper maintenance/runtime path for managed credential startup:
managed env template entries
-> resolveCredentials first-pass tracking
-> hosted connect retry list
This PR does not broaden behavior beyond the optimization scope.
What changed
Optimized connectable credential collection in internal/run
Removed the extra disconnected-failure rescan before hosted connect retries
Preserved retry ordering, provider grouping, and launch warning behavior
Updated tests for connectable entry ordering
Verification
go test ./internal/run -run 'TestResolveCredentialsUsesInjectedProvider|TestSortedConnectableEntriesOrdersByEnvVar|TestResolveCredentialsReturnsIdentityMismatchError'
go test ./internal/guard/judge -run 'TestStartLlamaServerHealthCheckAndStop|TestStartLlamaServerEarlyExitDoesNotWaitForStopTimeout' -count=1 -v
go test ./internal/guard/judge -count=1
go test ./...
go vet ./...
git diff --check