[AUTOMATION] fix: optimize auth login scope dedup#248
Open
michiosw wants to merge 1 commit into
Open
Conversation
Greptile SummaryThis PR optimizes OAuth login scope assembly. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(auth): optimize login scope dedup" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This optimizes auth login scope resolution by deduplicating requested scopes in one pass.
Before this, every extra scope scanned the already-built slice in internal/auth/oidc.go, which turned duplicate filtering into repeated linear work.
Now a small seen-set is the canonical path:
Why
This gives kontext-cli a cheaper runtime path for OAuth login scope assembly:
login request
-> resolveLoginScopes
-> ordered deduplicated scope list
This PR does not broaden behavior beyond the optimization scope.
What changed
Optimized OAuth login scope dedup in
resolveLoginScopesRemoved repeated linear membership scans for every requested scope
Preserved scope order and default-vs-identity scope behavior
Updated tests for repeated custom scope deduplication
Verification
go test ./internal/auth
go test ./internal/guard/judge
go test ./...
go vet ./...
git diff --check