[AUTOMATION] fix: optimize internal/run connectable credential scan#244
Open
michiosw wants to merge 1 commit into
Open
[AUTOMATION] fix: optimize internal/run connectable credential scan#244michiosw wants to merge 1 commit into
michiosw wants to merge 1 commit into
Conversation
Greptile SummaryThis PR changes how disconnected credentials are collected during credential resolution. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(run): avoid rescanning disconnected ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This optimizes internal/run credential startup by collecting connectable entries during the first resolution pass.
Before this, disconnected credential failures lived in
internal/run/run.go, then the code rescanned the failure map to rebuild the same connectable entry list before hosted connect could start.Now the first resolution pass is the canonical path:
Why
This gives kontext-cli a cheaper maintenance/runtime path for hosted credential startup:
managed
kontext start->
resolveCredentials-> sorted connectable entries without a second failure-map scan
This PR does not broaden behavior beyond the optimization scope.
What changed
Optimized connectable credential collection in
internal/run/run.goRemoved the extra failure-map rescan before hosted connect starts
Preserved connectable entry ordering and existing warning flow
Updated no behavior outside the hosted credential startup path
Verification
go test ./internal/run
go test ./...
go test ./internal/guard/judge -run 'TestStartLlamaServerHealthCheckAndStop|TestStartLlamaServerEarlyExitDoesNotWaitForStopTimeout' -count=1 -v
go test ./internal/guard/judge -count=1
go vet ./...
git diff --check