Test PR#7
Conversation
Specify namespace in examples
|
|
||
| it "should return correct apr value" do | ||
| loan = Loan.new(15, 36, 10000, 5, 3, 10) | ||
| loan = Loan.new(nominal_rate: 15, duration: 36, amount: 10000, structure_fee: 5, currency_protection: 3, fee: 10) |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
Metrics/LineLength: Line is too long. [119/80]
|
|
||
| it "should return correct apr value" do | ||
| loan = Loan.new(13, 1, 50000000) | ||
| loan = Loan.new(nominal_rate: 13, duration: 1, amount: 50000000) |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
|
|
||
| it "should return correct apr value" do | ||
| loan = Loan.new(13, 90, 50000000) | ||
| loan = Loan.new(nominal_rate: 13, duration: 90, amount: 50000000) |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
|
|
||
| it "should return correct apr value" do | ||
| loan = Loan.new(13, 90, 10000000) | ||
| loan = Loan.new(nominal_rate: 13, duration: 90, amount: 10000000) |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
|
|
||
| it "should return correct apr value" do | ||
| loan = Loan.new(13, 36, 10000) | ||
| loan = Loan.new(nominal_rate: 13, duration: 36, amount: 10000) |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
|
|
||
| it "should return correct pmt value" do | ||
| loan = Loan.new(13, 90, 1000000) | ||
| loan = Loan.new(nominal_rate: 13, duration: 90, amount: 1000000) |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
|
|
||
| it "should return correct pmt value" do | ||
| loan = Loan.new(0, 6, 10000) | ||
| loan = Loan.new(nominal_rate: 0, duration: 6, amount: 10000) |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
|
|
||
| it "should return correct pmt value" do | ||
| loan = Loan.new(0, 36, 10000) | ||
| loan = Loan.new(nominal_rate: 0, duration: 36, amount: 10000) |
There was a problem hiding this comment.
Style/NumericLiterals: Use underscores(_) as decimal mark and separate every 3 digits with them.
| @@ -1,3 +1,3 @@ | |||
| module FinanceMath | |||
| VERSION = "1.0.1" | |||
| VERSION = "1.0.5" | |||
There was a problem hiding this comment.
Style/MutableConstant: Freeze mutable objects assigned to constants.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
|
||
| private | ||
|
|
||
| def initialize_options(options) |
There was a problem hiding this comment.
Layout/IndentationConsistency: Inconsistent indentation detected.
5 participants
No description provided.