Improved continuous integration testing#326
Merged
mhoemmen merged 10 commits intokokkos:mainfrom Apr 30, 2026
Merged
Conversation
CMake may require Visual Studio to be listed as the generator, but that should be the default generator on Windows. Guess we'll find out!
$GITHUB_WORKSPACE does not work on Windows, so I replaced it with the hopefully OS agnostic ${{ github.workspace }}
The explicit paths were Linux-style, and Windows did not read them correctly.
Contributor
Author
|
The C++17 build is broken. I'll submit a separate PR fixing it. |
Added fail-fast option to prevent cancellation of other builds.
Fix C++17 build
Contributor
Fix suggestions
|
amklinv-nnl
added a commit
to NavalNuclearLab/stdBLAS
that referenced
this pull request
Apr 29, 2026
Thanks to @mhoemmen for the suggestion!
Thanks to @mhoemmen for the suggestion!
Contributor
Author
|
@mhoemmen I implemented the changes you suggested, and the build/tests are passing. Kindly consider accepting this PR at your convenience! |
mhoemmen
approved these changes
Apr 30, 2026
Contributor
mhoemmen
left a comment
There was a problem hiding this comment.
Thanks for the fixes! : - )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now supports Windows/MSVC as well as Linux/gcc and MacOS/clang. Also tests for both 17 and 20 standard compatibility.