Skip to content

feat: nested selectors with lightningcss.#92

Merged
knightedcodemonkey merged 1 commit into
mainfrom
bananas
May 24, 2026
Merged

feat: nested selectors with lightningcss.#92
knightedcodemonkey merged 1 commit into
mainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 24, 2026 18:54
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.71%. Comparing base (b60f336) to head (34f0aed).

Files with missing lines Patch % Lines
packages/css/src/css.ts 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   90.67%   90.71%   +0.04%     
==========================================
  Files          18       18              
  Lines        6496     6535      +39     
  Branches     1176     1178       +2     
==========================================
+ Hits         5890     5928      +38     
- Misses        569      570       +1     
  Partials       37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Lightning CSS draft nesting support (enabled by default) so nested selectors work in CSS Modules, and updates related dependencies/CI tooling to support the change.

Changes:

  • Enable drafts.nesting by default when running Lightning CSS transforms, while preserving the ability to explicitly disable it.
  • Add fixtures and tests validating nested selector handling for CSS Modules (Node + browser/WASM paths).
  • Bump package versions and update CI/workflow toolchain versions (Node matrix and GitHub Actions).

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/playwright/package.json Updates fixture app dependencies to consume @knighted/css@1.2.1 and newer @knighted/jsx.
packages/css/test/fixtures/misc/module-nesting/entry.js Adds a JS entry fixture importing a CSS module for nesting coverage.
packages/css/test/fixtures/misc/module-nesting/button.module.css Adds a CSS Modules fixture using nested selectors (&:hover).
packages/css/test/css.test.ts Adds a test asserting nested selectors work with Lightning CSS defaults in CSS Modules mode.
packages/css/test/css.browser.test.ts Extends the browser/WASM transform hook test to ensure drafts.nesting is passed through.
packages/css/src/css.ts Introduces a narrow local type widening and defaults drafts.nesting to true in normalized Lightning CSS options.
packages/css/src/browser.ts Extends WASM transform typings and passes drafts.nesting: true for CSS Modules in browser mode.
packages/css/package.json Bumps package version and pins lightningcss dependency to 1.30.1; updates oxc-parser.
package.json Updates dev tool dependencies and adds overrides to pin lightningcss and constrain c8’s yargs.
.github/workflows/publish.yml Updates action versions and Node version used for publishing.
.github/workflows/playwright.yml Updates action versions and Node versions used for Playwright E2E runs.
.github/workflows/ci.yml Expands the Node matrix and updates action versions, including Codecov action.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit e7fc83c into main May 24, 2026
9 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch May 24, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants