fix: axis drag stops when cursor leaves the axis widget bounding box - #824
Open
dylansproule wants to merge 1 commit into
Open
fix: axis drag stops when cursor leaves the axis widget bounding box#824dylansproule wants to merge 1 commit into
dylansproule wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #794
Problem
Dragging the X/Y axis to scroll or zoom stops as soon as the cursor moves outside the widget's bounding box, because the drag handlers are driven by
_findWidgetByEventinEvent.ts, which only resolves a widget when the pointer is over it.Change
Moved the axis drag scaling logic out of
Event.tsinto the axis widgets themselves (mirroring the existingSeparatorWidgetpattern):YAxisWidgetnow owns Y-axis drag scaling, manual-axis range sync, and the double-click reset (zoomYAxis/resetYAxisAndManualYAxes), registeringmouseDownEvent/pressedMouseMoveEvent/mouseUpEventhandlers.XAxisWidgetnow owns X-axis zoom-on-drag with the same handlers.Event.tsroutes X_AXIS/Y_AXIS mouse and touch down/move/up events throughthis._mouseDownWidgetso the drag target is fixed at pointer-down and the handlers continue firing regardless of where the cursor is.mouseWheelVertEventandmouseDoubleClickEventnow delegate to the widget public methods.Notes
_processMainScrollingEventstays inEvent.ts(MAIN widget behavior unchanged).