Conversation
54b266c to
5b6bd13
Compare
|
Thanks, but I have NAK'd this multiple times. This needs to inherit from the base UV-K5 driver, participate in the detection scheme, and not just duplicate/reimplement everything from the base driver. Last I looked at this, it was forked from one of the earlier versions of the driver which means it committed all the same sins that had to be fixed before we could merge the base driver into the tree. Given the huge amount of silly manual data structures in this commit, the still-present duplication of things in the base driver and common code, I'm guessing that not much has changed. |
e879fc8 to
d2f8bcc
Compare
|
Hi Dan, I have refactored the driver to address your feedback. Here is a summary of the changes implemented in the latest commit:
All GHA checks and unit/driver tests are now passing successfully. Please let me know if any further adjustments are needed. Thank you! |
| try: | ||
| import wx | ||
| except ImportError: | ||
| wx = None |
There was a problem hiding this comment.
You may not import webbrowser or wx, nor try to manipulate the GUI in any way from the driver.
This adds support for the custom F4HWN Fusion firmware on the Quansheng UV-K1 & UV-K5 V3 radios. It implements the custom EEPROM memory layout and extra features supported by this firmware.
|
is now everything OK? |
This pull request introduces a new driver (
chirp/drivers/uvk5_f4hwn.py) to support the custom F4HWN Fusion firmware on the Quansheng UV-K1 and UV-K5 V3 radios.The driver has been cleaned up and formatted according to PEP8 guidelines using
autopep8to ensure it passes CHIRP linting checks. Unused variables and syntax issues have been resolved. The driver class is registered asUVK5RadioF4HWNunder the vendorQuanshengand modelUV-K1 & UV-K5 V3 (F4HWN Fusion).Improvements
List [1]toList [24]in the memory grid, the driver now reads the user-defined names directly from the radio settings structure, displaying the actual custom names (e.g.,PMR,AIR) when set.Credits & Acknowledgement
This driver is based on the hard work and adaptations of the following authors in the community:
sq5bpf@lipkowski.org): Creator of the original Quansheng UV-K5 driver.We are submitting this driver on behalf of the community to integrate standard support for the F4HWN Fusion firmware directly into CHIRP next.