Skip to content

chirpc: Fix exit code on successful --download-mmap and --upload-mmap #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eflowkram wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chirpc: Fix exit code on successful --download-mmap and --upload-mmap #1572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions chirp/cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,9 +379,11 @@ def main(args=None):
try:
radio.sync_in()
radio.save_mmap(options.mmap)
LOG.info("Download successful: %s", options.mmap)
sys.exit(0)

@kk7ds kk7ds May 5, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to not exit(0) anywhere and take that default if we fall out the bottom with nothing failing. Just moving the exit(1) into the exception handler would take care of that. That would solve the problem right?

Really, sys.exit() anywhere in the middle of something is a bad pattern (this code is super old) but especially forcing exit success in the middle is pretty weird.

except Exception as e:
LOG.exception(e)
sys.exit(1)
sys.exit(1)

if options.upload_mmap:
if not issubclass(rclass, chirp_common.CloneModeRadio):
Expand All @@ -394,9 +396,10 @@ def main(args=None):
radio.load_mmap(options.mmap)
radio.sync_out()
print("Upload successful")
sys.exit(0)
except Exception as e:
LOG.exception(e)
sys.exit(1)
sys.exit(1)

if options.mmap and isinstance(radio, chirp_common.CloneModeRadio):
radio.save_mmap(options.mmap)
Loading