Skip to content

Refactorings: Fix clang fomat findingd - #28

Merged
kimkulling merged 2 commits into
mainfrom
feature/imagebox_feature
Apr 10, 2026
Merged

kimkulling merged 2 commits into
mainfrom
feature/imagebox_feature

Conversation

@kimkulling

@kimkulling kimkulling commented Apr 10, 2026 •

Copy link
Copy Markdown
Owner
  • Replace NULL with nullptr
  • Fix typos in documentation
  • Remove redundant namespaces

Summary by CodeRabbit

  • Chores

    • Updated minimum CMake version requirement to ensure compatibility with modern build environments.
  • Style

    • Code formatting improvements for better readability.

@coderabbitai

coderabbitai Bot commented Apr 10, 2026 •

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 86a6794a-86f4-4115-a4c1-97c9903a9e12

📥 Commits

Reviewing files that changed from the base of the PR and between b1ab18a and e407c36.

📒 Files selected for processing (2)
  • CMakeLists.txt
  • src/backends/sdl2_renderer.cpp

Walkthrough

Updated CMake minimum version requirement from 3.5 to 3.10. Reformatted the Renderer::drawText function declaration with line wrapping for improved readability without changing any logic or behavior.

Changes

Cohort / File(s) Summary
Build Configuration
CMakeLists.txt
Updated minimum required CMake version from 3.5 to 3.10.
Code Formatting
src/backends/sdl2_renderer.cpp
Reformatted Renderer::drawText function declaration with line wrapping across parameters. No logic or signature changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/imagebox_feature

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kimkulling
kimkulling merged commit f0fdce0 into main Apr 10, 2026
1 check passed
@kimkulling
kimkulling deleted the feature/imagebox_feature branch April 10, 2026 17:05
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant