chore(core): remove jsonpp 🔱#15835
Draft
mcdurdin wants to merge 2 commits intochore/core/embed-osk/move-test-helpersfrom
Draft
chore(core): remove jsonpp 🔱#15835mcdurdin wants to merge 2 commits intochore/core/embed-osk/move-test-helpersfrom
mcdurdin wants to merge 2 commits intochore/core/embed-osk/move-test-helpersfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ceb8ec4 to
f19e695
Compare
jsonpp was being used only in a single unit test, and so this was a lot of overhead and complexity for very little benefit. We may want to add some more unit tests in the future for state_api.tests.cpp to do a deep comparison of the state? Test-bot: skip
f19e695 to
35e09ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonpp was being used only in a single unit test, and so this was a lot of overhead and complexity for very little benefit. We may want to add some more unit tests in the future for state_api.tests.cpp to do a deep comparison of the state?
Also: move keyboard_api and options_api tests to gtest - working on this precipitated the jsonpp removal.
Test-bot: skip