Skip to content

chore(core): remove jsonpp 🔱#15835

Draft
mcdurdin wants to merge 2 commits intochore/core/embed-osk/move-test-helpersfrom
chore/core/remove-jsonpp
Draft

chore(core): remove jsonpp 🔱#15835
mcdurdin wants to merge 2 commits intochore/core/embed-osk/move-test-helpersfrom
chore/core/remove-jsonpp

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

jsonpp was being used only in a single unit test, and so this was a lot of overhead and complexity for very little benefit. We may want to add some more unit tests in the future for state_api.tests.cpp to do a deep comparison of the state?

Also: move keyboard_api and options_api tests to gtest - working on this precipitated the jsonpp removal.

Test-bot: skip

@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Apr 10, 2026

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Developer
    • Keyman Developer - build : all tests passed (no artifacts on BuildLevel "build")
    • Compiler Regression Tests - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman Developer (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip - build : all tests passed (no artifacts on BuildLevel "build")
    • kmcomp.zip (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • Keyboards
    • Test Keyboards - build : all tests passed (no artifacts on BuildLevel "build")
  • macOS
    • Keyman for macOS - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for macOS (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
  • Web
    • KeymanWeb Test Home - build : all tests passed (no artifacts on BuildLevel "build")
  • Windows
    • Keyman for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Windows (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Keyman for Windows (old PRs) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (ARM64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x86) - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot bot changed the title chore(core): remove jsonpp chore(core): remove jsonpp 🔱 Apr 10, 2026
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S26 milestone Apr 10, 2026
@mcdurdin mcdurdin force-pushed the chore/core/remove-jsonpp branch 4 times, most recently from ceb8ec4 to f19e695 Compare April 10, 2026 14:04
jsonpp was being used only in a single unit test, and so this was a lot
of overhead and complexity for very little benefit. We may want to add
some more unit tests in the future for state_api.tests.cpp to do a
deep comparison of the state?

Test-bot: skip
@mcdurdin mcdurdin force-pushed the chore/core/remove-jsonpp branch from f19e695 to 35e09ca Compare April 11, 2026 05:40
@keyman-server keyman-server modified the milestones: A19S26, A19S27 Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants