Skip to content

[Hosted cutover 2/17] Load complete hosted parity snapshots - #2574

Open
salmonumbrella wants to merge 3 commits into
kenn-io:mainfrom
salmonumbrella:feat/hosted-cutover-02-physical-parity-snapshots
Open

salmonumbrella wants to merge 3 commits into
kenn-io:mainfrom
salmonumbrella:feat/hosted-cutover-02-physical-parity-snapshots

Conversation

@salmonumbrella

@salmonumbrella salmonumbrella commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Builds on #2573.

Incremental diff for this part.

What changed

Add physical session snapshots and source-readiness counts inside a caller-owned read-only transaction. Include retained and trashed rows, complete transcripts, tool results, usage and findings without served-view limits.

Why

Cutover checks need the complete stored history, including records the dashboard does not show. Public list and transcript readers cannot provide that evidence.

Load-complete-hosted-parity-snapshots.mp4

Usage

No usage change. This supplies the physical reads used by the parity command later in the series.

Refs #1352.

@roborev-ci

roborev-ci Bot commented Oct 31, 2026

Copy link
Copy Markdown

roborev: Combined Review (5aa7bac)

Verdict: Changes require fixes for 2 findings.

Medium

  • internal/rawparity/normalize.go:50: Parity snapshots omit session_plan_usage, so Codex Cloud sessions with matching transcripts and usage_events can produce identical digests despite missing or different credits, plan percentages, coverage, or CountedUnder ownership. Cutover comparison can therefore miss accounting loss.

    Fix: Include session_plan_usage in Snapshot, load it within the same transaction, and compare its accounting fields with timestamp normalization and CountedUnder relationship mapping. Add coverage for differing and missing plan usage rows.

  • internal/rawparity/normalize_test.go:225: TestFrictionPhysicalIdentityFormatting duplicates TestFrictionIdentityMinimalCounterexample at internal/rawparity/normalize_test.go:269. Both detect friction titles or fingerprints incorrectly participating in parity; the generated suffix exercises no additional normalization behavior.

    Fix: Delete TestFrictionPhysicalIdentityFormatting and retain TestFrictionIdentityMinimalCounterexample, which also runs when Hegel tests are skipped.


Reviewers: 2x codex, codex (security), codex (test-value) | Synthesis: codex, 14s | Total: 8m11s

@salmonumbrella
salmonumbrella force-pushed the feat/hosted-cutover-02-physical-parity-snapshots branch from 5aa7bac to b1292f2 Compare October 31, 2026 20:43
@roborev-ci

roborev-ci Bot commented Oct 31, 2026

Copy link
Copy Markdown

roborev: Combined Review (b1292f2)

Verdict: No findings at or above medium severity.


Reviewers: 2x codex, codex (security), codex (test-value) | Synthesis: codex, 11s | Total: 7m38s

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant