You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add physical session snapshots and source-readiness counts inside a caller-owned read-only transaction. Include retained and trashed rows, complete transcripts, tool results, usage and findings without served-view limits.
Why
Cutover checks need the complete stored history, including records the dashboard does not show. Public list and transcript readers cannot provide that evidence.
Load-complete-hosted-parity-snapshots.mp4
Usage
No usage change. This supplies the physical reads used by the parity command later in the series.
internal/rawparity/normalize.go:50: Parity snapshots omit session_plan_usage, so Codex Cloud sessions with matching transcripts and usage_events can produce identical digests despite missing or different credits, plan percentages, coverage, or CountedUnder ownership. Cutover comparison can therefore miss accounting loss.
Fix: Include session_plan_usage in Snapshot, load it within the same transaction, and compare its accounting fields with timestamp normalization and CountedUnder relationship mapping. Add coverage for differing and missing plan usage rows.
internal/rawparity/normalize_test.go:225: TestFrictionPhysicalIdentityFormatting duplicates TestFrictionIdentityMinimalCounterexample at internal/rawparity/normalize_test.go:269. Both detect friction titles or fingerprints incorrectly participating in parity; the generated suffix exercises no additional normalization behavior.
Fix: Delete TestFrictionPhysicalIdentityFormatting and retain TestFrictionIdentityMinimalCounterexample, which also runs when Hegel tests are skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #2573.
Incremental diff for this part.
What changed
Add physical session snapshots and source-readiness counts inside a caller-owned read-only transaction. Include retained and trashed rows, complete transcripts, tool results, usage and findings without served-view limits.
Why
Cutover checks need the complete stored history, including records the dashboard does not show. Public list and transcript readers cannot provide that evidence.
Load-complete-hosted-parity-snapshots.mp4
Usage
No usage change. This supplies the physical reads used by the parity command later in the series.
Refs #1352.