Repository navigation
ci(sibling-pins): skip validation on PR text edits - #2546
Conversation
New PR commits make earlier dependency verdicts obsolete. Stop those runs so they release runners for the current commit, while each merge-group run keeps its own result.
Changing a PR title or description leaves its dependency files unchanged. Reserve runner time for events that can change the dependency verdict.
The sibling pin check reads the proposed merge with the PR's base. A new base can bring different dependency pins, so dropping all PR edits left a stale verdict after a retarget. Title and description edits still cannot change that verdict and skip the check. A skipped job reports success. The skipped run gets its own check name so it cannot satisfy the required sibling check. It also gets its own concurrency group, so a text edit cannot cancel a check that is still running for the latest commit.
Replacement dependency checks need the same cancellation group even when an event omits pull request details. A single merge-ref key keeps those runs together while text-only edits retain their independent groups.
A title or description edit must preserve an active sibling check and its required result, while a base edit still needs validation. Keep that rationale next to the cancellation groups so later workflow changes retain both cases.
roborev: Combined Review (
|
GitHub can show a conditional job name as its literal expression when the job is skipped. Keep the check name readable for title and body edits, and describe the existing skip and cancellation behavior accurately.
roborev: Combined Review (
|
Check consumers group results by name. Skipped title and body edits need a distinct name so they leave the dependency verdict visible while avoiding runner work for those edits.
roborev: Combined Review (
|
roborev: Combined Review (
|
Editing an agentsview PR's title or description no longer starts a sibling-pin check, which caused 36% of agentsview's sibling-pin runs last week (269 of 755). A change to the PR's base branch still reruns the check, since it can change which pins are valid.