feat: adopt host Action for Kandy top bar - #23
Draft
carlosflorencio wants to merge 2 commits into
Draft
carlosflorencio wants to merge 2 commits into
carlosflorencio wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Kandy uses Kandev's host-owned
ui.Actionin the chat top bar when that API is available. The Action owns the control shell; Kandy's decorative creature SVG is sized to the host's 16px glyph box. The existing preview, dialog, animation state, reduced-motion behavior, data refresh, and lifecycle remain intact. Older supported hosts use the legacy native button.The Action's accessible label now uses the host plugin-translation catalog, with an English fallback. Level, stage, mood, and sleep state remain in the label.
Compatibility and pins
0.83.0; plugin ID, registration slot, manifest version, configuration, permissions, and state are unchanged..kandev-sdk-refpins the source API contract to570600439036e81f8e9e1c63f15c4abce8a6c846, containing merged Kandev PR #3943.Verification
make check-format vet testpassed: Go tests, 98 UI tests, and positive/negative package and release verifier checks.TMPDIR=<short task-owned cache directory> make build package-host packagepassed. The package verifier checked the host package and all five declared platform binaries, UI assets, manifest, exact inventory, and SHA-256 checksums.kandev-plugin-kandy-0.14.0.tar.gzin an isolated built Kandev host at570600439036e81f8e9e1c63f15c4abce8a6c846; the Action path passed.v0.83.0host at9a3f2242242bd50feb8bc0784d51e8d81c9d85d9; the legacy path passed.node scripts/smoke-real-host.mjs <host-root> kandev-plugin-kandy-0.14.0.tar.gz <action|legacy> <port> <artifacts-dir>. README documents locked dependency setup and host revisions. JSON measurements, host logs, and screenshots are retained in the task workspace atreal-hosts/artifacts/actionandreal-hosts/artifacts/min-host.Limitations and overlap
The pinned source host is not a stable Kandev release. The Action path still requires validation against a stable release containing PR #3943 before this package can be merged. Existing overlapping PRs #20, #11, and #21 were left untouched.
Release hold: do not merge until a stable Kandev release includes PR #3943 and this package has been validated against that release.