feat/fedex pickup improvements#1114
Open
ChrisNolan wants to merge 6 commits into
Open
Conversation
Fedex docs say Placeholder for any message to be passed to the FedEx pickup courier. Note:Maximum length is 60 characters. Example: Please ring bell at loading dock. Which makes up with the purpose of the field and how it is used by other connectors
- 🛠️ Added `validate_package_location` utility to ensure valid package locations for FedEx pickups. - 🔄 Updated `pickup_request` and `pickup_update_request` to use validated package location. - 🧪 Added tests for invalid package location scenarios in `test_pickup.py`.
missed in commit 94f81ef
- Add `resolve_notification_emails` function to consolidate email retrieval from payload options. - Implement `build_notification_email_details` to format email details for FedEx requests. - Update pickup request and update request functions to utilize new email handling logic. - Add tests for handling multiple notification emails and validation for email limits.
|
@ChrisNolan is attempting to deploy a commit to the karrio Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #1112