Skip to content

Fix executor instrumentation by unordered config merging#1395

Merged
ivantopo merged 1 commit into
kamon-io:masterfrom
Forbiddensequence:feature/fix-executor-intstrumetnation
Jul 1, 2025
Merged

Fix executor instrumentation by unordered config merging#1395
ivantopo merged 1 commit into
kamon-io:masterfrom
Forbiddensequence:feature/fix-executor-intstrumetnation

Conversation

@Forbiddensequence

Copy link
Copy Markdown
Contributor

Fixes #1294

@mkurz

mkurz commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

@ivantopo can you please merge this? This is such a low hanging fruit...

@Forbiddensequence Forbiddensequence force-pushed the feature/fix-executor-intstrumetnation branch from 47509c4 to 4ec1f50 Compare June 28, 2025 12:49
@ivantopo

ivantopo commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Sorry guys, I know this looks like extremely low hanging fruit that should be handled faster. I didn't merge it yet because I remember having a similar issue many year ago and trying to use the += operator but that didn't work out. I vaguely remember having situations where the config wouldn't resolve because of adding to an array that doesn't exist, but that was so long ago and I can't find any traces of it.

So I thought I'll first try a few things in different types of applications and then merge it if I can't reproduce whatever issue I had in the past. I'll try to do that now while the tests run :D

@ivantopo

ivantopo commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

I couldn't find any obvious way to break this so we are merging it and hoping it will all be fine 😄

@ivantopo ivantopo merged commit 4fb0167 into kamon-io:master Jul 1, 2025
2 checks passed
@ivantopo

ivantopo commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Thank you @Forbiddensequence for the fix 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Context propagation is broken from Akka 2.8.0 onwards

3 participants