Repository navigation
Allow module paths in modifiers(...) - #1657
Open
thelastbackspace wants to merge 2 commits into
Open
thelastbackspace wants to merge 2 commits into
thelastbackspace wants to merge 2 commits into
Conversation
modifiers(&module::Addon) failed to parse because each modifier was parsed as a single Ident. Parse a syn::Path instead so module-qualified modifiers work the same as the bare form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[openapi(modifiers(&somewhere::SecurityAddon))]didn't compile ("expected,") because each modifier was parsed as a bareIdent, so onlymodifiers(&SecurityAddon)with the type imported into scope worked.I changed
Modifierto parse asyn::Pathinstead, so&module::Addon,&crate::module::Addonetc. work the same as the bare form. The bare form is still just a one-segment path, so nothing changes for existing users.Added a test in
modify_test.rsthat uses a modifier from a nested module. It fails to compile without the change and passes with it. The rest of the utoipa-gen tests pass with the feature set from the justfile.Fixes #1430