refactor(tjsp): decompõe download do CJPG - #334
Draft
bdcdo wants to merge 3 commits into
Draft
Conversation
12 tasks
bdcdo
commented
Jul 15, 2026
bdcdo
left a comment
Collaborator
Author
There was a problem hiding this comment.
Revisão pré-merge concluída no commit 1b3acf4.
- Removi o callback opcional e a closure do client; o download usa diretamente
cjpg_n_pags. - Preservei diagnóstico, causa da exceção, paginação e retorno público em
str, comPathapenas internamente. - A suíte offline passou com 1.751 testes;
cjpg_downloadficou em CCN 8/cognitivo 6 e pre-commit passou.
O GitHub não reporta checks para esta branch. Mantive o PR em draft e não fiz merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumo
cjpg_debug, o HTML diagnóstico e o encadeamento da exceção quando a contagem falha.rangecom passo, URLs, ordem das requisições e pausas entre páginas.Simplificação da revisão
cjpg_downloadchama diretamente a fonte canônicacjpg_n_pags.Pathinternamente e converte parastrsomente na fronteira pública; consolida helpers duplicados nos testes.Complexidade
cjpg_download: CCN 8 e complexidade cognitiva 6.Validação
uv run pytest: 1.751 testes passaram, 32 foram ignorados e 220 ficaram desmarcados.git diff --check: passaram.Refs #307