Skip to content

Removed white background to be fully compliant with Bootstrap.#226

Open
diosney wants to merge 1 commit into
jschr:masterfrom
diosney:master
Open

Removed white background to be fully compliant with Bootstrap.#226
diosney wants to merge 1 commit into
jschr:masterfrom
diosney:master

Conversation

@diosney

@diosney diosney commented Mar 14, 2014

Copy link
Copy Markdown

Fixes #225

@jschr

jschr commented Mar 15, 2014

Copy link
Copy Markdown
Owner

This was an intended design change and has been like this since release. Since this plugin was meant to largely address the stacking modal issue, I believe that the white background works best. However this is a personal preference, so I will leave this PR open. If there is more support for reverting the colour back to black, I will consider changing it.

@diosney

diosney commented Mar 17, 2014

Copy link
Copy Markdown
Author

Ok.

Since this plugin was meant to largely address the stacking modal issue, I believe that the white > background works best.

What do you mean with that? I reverted to use a black/grayish background and the color stacking works perfect for me (they decrease in opacity as more modals are stacked, darkening the last opened modal).

@jschr

jschr commented Mar 17, 2014

Copy link
Copy Markdown
Owner

It definitely works functionally. It was personal preference from the beginning since bootstrap is predominantly used with a light theme. I believed it was smoother having the page fade to white as opposed to black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please, remove white background on overlay

2 participants