Mark live departure times, and show clock times for later buses - #118
Merged
Merged
Conversation
A timetable-only time looked exactly like one from a tracked bus. Live
times (the backend sent a delay) now carry the real-time symbol, and
scheduled ones go without it in a muted colour.
From 20 minutes out a departure shows its clock time ("18:42") instead
of "1h 12min": easier to plan with, and it matches the printed timetable.
The countdown logic moves into a plain function so it can be tested.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015L2XVVs7zvasvQEmM78ZMV
The wrapper is pinned to 9.6.1 because 9.7 doesn't work with the current IntelliJ, but Renovate kept proposing 9.7.1 (#84, #117). 9.6.x patch releases are still allowed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015L2XVVs7zvasvQEmM78ZMV
Countdowns rounded down, so "Due" showed up to 59 seconds early and "1 min" covered anything up to 1m59s. Departure lists, the tracking card and the route map's bus card now share one rounding helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015L2XVVs7zvasvQEmM78ZMV
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015L2XVVs7zvasvQEmM78ZMV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delaySecondsnon-null) show the real-time symbol before the time. Timetable-only departures have no symbol and a muted colour, so they no longer look like a tracked bus. Applies to My stops, a route's stop departures and the map stop sheet.19:36) instead of a countdown (1h 12min). Nearer departures still count down. The tracking card follows the same rule.minutesUntil()helper.departureWhen()and covered byDepartureDisplayTest.live_time("Live time" / "Am beo", the icon's accessibility label) and removes the now-unusedcountdown_hours_min.allowedVersions: "<9.7"), since 9.7 doesn't work with the current IntelliJ. 9.6.x patch releases still come through. This should make Renovate close Update Gradle to v9.7.1 #117.Please check the Irish: "Am beo" is my translation.
Test plan
:shared:jvmTest(73 pass) andtestAndroidHostTest🤖 Generated with Claude Code
https://claude.ai/code/session_015L2XVVs7zvasvQEmM78ZMV