Repository navigation
fix: lock screen by default if lockscreen enabled - #1400
Merged
gerhardol merged 1 commit intoOct 18, 2026
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Unlocking can interrupt recording, default settings remain unprotected, and some screen regions bypass gesture detection.
3 open issues
What changed in this PR
This PR aims to prevent accidental recording interruptions by improving the recording screen’s button guard.
Changes:
- Initializes locking from preferences and adds Stop/Pause feedback.
- Changes toggling to three rapid taps and expands touch handling.
- Adds a gray Stop-button background and updates instructions.
| File | Description |
|---|---|
| common/src/main/res/values/strings.xml | Updates lock-toggle instructions. |
| app/src/main/org/runnerup/view/RunActivity.java | Changes guard initialization, gestures, and button handling. |
| app/res/drawable/btn_gray.xml | Adds the locked Stop-button background. |
Review effort: Balanced
Give feedback also tapping on pause/stop. Tap anywhere on screen to toggle state, not just header. Check 3 taps in one sec, not 5. Enable tapguard by default if RU is showing on lockscreen.
gerhardol
force-pushed
the
feature/lockbuttons-tapping
branch
from
October 18, 2026 18:38
c88fc69 to
6c4b2f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give feedback also tapping on pause/stop.
Tap anywhere on screen to toggle state, not just header. Check 3 taps in one sec, not 5.
Enable tapguard by default if RU is showing on lockscreen.
--
When showing on lockscreen, I have several times accidentally failed to record as recording stopped when putting the phone in the pocket