Repository navigation
Conversation
Integrate makefile.locale compilation logic directly into main Makefile. This eliminates the two-phase build process by discovering .adoc files dynamically at build time using shell commands instead of make wildcards. Key changes: - Add asciidoctor compilation rules directly in Makefile - Use BUILD_LANG_DOCS define to build manpages and HTML after po4a translation - Discover files dynamically with find at build time, not parse time - Preserve parallel build capability with make's job control - Support all existing targets: all, man, html, clean, mrproper, install The makefile.locale is retained for backward compatibility but is no longer invoked by the main build process. Co-authored-by: jnavila <156172+jnavila@users.noreply.github.com>
Co-authored-by: jnavila <156172+jnavila@users.noreply.github.com>
Co-authored-by: jnavila <156172+jnavila@users.noreply.github.com>
jnavila
left a comment
There was a problem hiding this comment.
Not what was intended. The compilation needs to be kept parallel and if possible use make rules.
There was a problem hiding this comment.
The changes to this file is not related to the main PR.
| @echo ' ' BUILD $(1) manpages | ||
| @if [ -d $(1) ]; then \ | ||
| cd $(1) && \ | ||
| for adoc in $$$$(find . -maxdepth 1 -name 'git-*.adoc' 2>/dev/null); do \ |
There was a problem hiding this comment.
This does not compile the files in parallel... What was expected is a recursive call to self.
There was a problem hiding this comment.
Fixed in commit 4f90d71. Now uses recursive make invocation with pattern rules to enable parallel compilation of .adoc files within each language directory.
| #, fuzzy | ||
| msgid "" | ||
| msgstr "Project-Id-Version: PACKAGE VERSION\nPOT-Creation-Date: 2026-01-16 21:44+0100\nPO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\nLast-Translator: FULL NAME <EMAIL@ADDRESS>\nLanguage-Team: LANGUAGE <LL@li.org>\nLanguage: \nMIME-Version: 1.0\nContent-Type: text/plain; charset=UTF-8\nContent-Transfer-Encoding: 8bit\n" | ||
| msgstr "Project-Id-Version: PACKAGE VERSION\nPOT-Creation-Date: 2026-01-23 21:23+0000\nPO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\nLast-Translator: FULL NAME <EMAIL@ADDRESS>\nLanguage-Team: LANGUAGE <LL@li.org>\nLanguage: \nMIME-Version: 1.0\nContent-Type: text/plain; charset=UTF-8\nContent-Transfer-Encoding: 8bit\n" |
There was a problem hiding this comment.
Remove this change. It is useless and pollutes the commit.
There was a problem hiding this comment.
Reverted the po/documentation.pot timestamp change in commit 4f90d71.
jnavila
left a comment
There was a problem hiding this comment.
This is not what was requested: No parallel build.
Replace shell for loops with recursive make invocation that uses pattern rules to compile .adoc files. This enables parallel compilation of files within each language directory using make's jobserver. Key changes: - Discover .adoc files dynamically at build time using shell find - Invoke make recursively with discovered files as targets - Use pattern rules (%.1: %.adoc) to compile files in parallel - Guard top-level rules with ifeq ($(lang),) to avoid conflicts - Guard pattern rules with ifneq ($(lang),) to only apply in language dirs The recursive make approach allows parallel compilation of individual files while discovering them dynamically after po4a creates them. Co-authored-by: jnavila <156172+jnavila@users.noreply.github.com>
Fixed in commit 4f90d71. The build now uses recursive make with pattern rules (%.1: %.adoc, etc.) to compile files in parallel, instead of shell for loops.
Fixed in commit 4f90d71. The compilation now uses make's pattern rules which enable parallel builds within each language directory using make's jobserver. |
|
Will not merge this. Too drafty. |
Problem
The build process required two phases: po4a creates .adoc files only when translation thresholds are met, but Make's
wildcardevaluates at parse time. This necessitated invokingmakefile.localein a second phase to discover and compile generated files.Solution
Integrated compilation logic into main Makefile using recursive make with pattern rules
wildcardwith dynamic shellfindto discover .adoc files at build timeBUILD_LANG_DOCSmacro that uses recursive make invocation with pattern rulesMAKE_TARGETdefine that delegated tomakefile.localeBefore:
After:
Key Benefits:
make allinvocationThe recursive make approach allows make to handle parallel compilation of individual .adoc files while discovering them dynamically after po4a creates them based on translation thresholds.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.