fix(desktop): compile rfd after nil-panel dialog_callback move (E0382) - #22
Merged
Merged
Conversation
The async sheet path moved the non-Copy Fn into RcBlock, then called it again when NSOpenPanel/NSSavePanel was nil (E0382). Complete as cancel first, matching stock rfd's single post-move use. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: jmfcamp <jmfcamp@users.noreply.github.com>
Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: jmfcamp <jmfcamp@users.noreply.github.com>
jmfcamp
marked this pull request as ready for review
August 20, 2026 22:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #20 (vendor wry/rfd nil-NSOpenPanel guard) and #21 (bare
return;→return Selfon the sync path). Apple Siliconjust desktop-release-buildstill failed in vendored rfd:dialog_callbackis a non-CopyFn. Stock rfd 0.16.0 builds the panel, then moves that callback into the sheetRcBlockonce. #20 madebuild_modalreturnOption<D>and added a nil-panel cancel after that move, so the laterdialog_callback(state, NSModalResponseCancel)was a use-after-move.The async sheet path now completes as
NSModalResponseCancelbefore creating theRcBlock— same cancel / no-path behavior, no second use of the moved Fn. Sync path from #21 is unchanged (return Self { state }).Hula branding is unchanged (
productNameHula Buzz, bundle idcom.huladesk.buzz,hulabuzz://). No extra crates vendored; no Tauri/wry bump.Related issue
N/A. Follow-up to #20 and #21. None found for the E0382 compile break.
Testing
macos_file_panel.rsnow assert the async sheet path cancels the nil panel beforeRcBlock::new(catches a regression to use-after-move). Existing E0069return Self { state }guard is unchanged. Those assertions pass.RcBlockmove: the old order is E0382; the new order compiles.just desktop-tauri-test(no GTK). Do not treat CI as picker reproduction.Verify on Apple Silicon / macOS 26:
just desktop-release-buildVite/chunk warnings and wry/rfd unused-unsafe warnings are not the failure.