Expend vsc detection#485
Open
attiasas wants to merge 15 commits into
Open
Conversation
attiasas
requested review from
a team,
agrasth,
bhanurp,
fluxxBot,
itsmeleela and
reshmifrog
reshmifrog
added
improvement
github-actions
Bot
removed
the
safe to test
reshmifrog
requested changes
Jun 12, 2026
| ) | ||
|
|
||
| var mergeVcsPropsForConan = civcs.MergeWithUserProps | ||
|
|
Contributor
There was a problem hiding this comment.
we need to have integration tests for all the changes done here in jfrog-cli , please add it
| log.Debug("No server details configured. Skipping property tagging.") | ||
| return | ||
| } | ||
| servicesManager, err := artCoreUtils.CreateServiceManager(ppc.serverDetails, -1, 0, false) |
Contributor
There was a problem hiding this comment.
why did we remove this , where we creating the servicemanger?
Contributor
|
the testcases are failing please take a look at them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
Changes
rt upload(generic upload)rt bp(buildinfo publish)