-
Notifications
You must be signed in to change notification settings - Fork 2
AX-1608 Add https://github.com/jfrog/jfrog-skills v11 #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1a48130
get skills from public repo
yanivt-jfrog 96b19ed
get skills from public repo
yanivt-jfrog 91580ee
get skills from public repo
yanivt-jfrog 58cd8ff
update comments
yanivt-jfrog 44db060
update version
yanivt-jfrog 5e8f944
Addressed david comments - change the version and move the sync skill
yanivt-jfrog 46ea65c
Update readme to point to skill repo prerequisite
yanivt-jfrog c3e1b6b
Update readme to point to skill repo prerequisite
yanivt-jfrog c35b4bc
merge main
yanivt-jfrog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "repo": "jfrog/jfrog-skills", | ||
| "pin": "v0.11.0", | ||
| "paths": ["skills"] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| #!/usr/bin/env node | ||
| // Vendors skill content from the upstream jfrog/jfrog-skills repository | ||
| // into this plugin. Run manually when bumping the pin: bump `pin` in | ||
| // sync-skills-vendor.json, then run this | ||
| // script to regenerate `skills/`, then commit both alongside each other. | ||
| // | ||
| // Usage: | ||
| // node .github/scripts/sync-skills.mjs | ||
| // | ||
| // Steps the script performs: | ||
| // 1. Reads sync-skills-vendor.json to learn which repo + ref to pull. | ||
| // 2. Downloads that tarball from codeload.github.com (public, no auth). | ||
| // 3. Extracts it into a temp directory. | ||
| // 4. Copies the requested paths (e.g. "skills") into the repo root, | ||
| // replacing any existing tree. | ||
| // | ||
| // The pin in sync-skills-vendor.json is the single source of truth — | ||
| // there is no runtime override. To ship a different skill version, | ||
| // change the pin in a PR and commit the synced tree alongside it. | ||
|
|
||
| import { promises as fs, createWriteStream } from "node:fs"; | ||
| import { Readable } from "node:stream"; | ||
| import { pipeline } from "node:stream/promises"; | ||
| import path from "node:path"; | ||
| import { spawnSync } from "node:child_process"; | ||
| import { tmpdir } from "node:os"; | ||
| import { fileURLToPath } from "node:url"; | ||
|
|
||
| // filesystem helpers | ||
| async function readJson(filePath) { | ||
| return JSON.parse(await fs.readFile(filePath, "utf8")); | ||
| } | ||
|
|
||
| async function fileExists(filePath) { | ||
| try { await fs.access(filePath); return true; } catch { return false; } | ||
| } | ||
|
|
||
| // download the upstream tarball | ||
|
|
||
| // codeload.github.com serves any public repo's archive over HTTPS | ||
| // without auth, accepting a tag, branch, or commit SHA as the ref. | ||
| async function downloadTarball(repo, ref, destPath) { | ||
| const url = `https://codeload.github.com/${repo}/tar.gz/${encodeURIComponent(ref)}`; | ||
| const res = await fetch(url, { redirect: "follow" }); | ||
| if (!res.ok) throw new Error(`Could not download ${repo}@${ref} (HTTP ${res.status})`); | ||
| await pipeline(Readable.fromWeb(res.body), createWriteStream(destPath)); | ||
| console.log(` fetched ${url}`); | ||
| } | ||
|
|
||
| // extract the tarball | ||
|
|
||
| // Shells out to the system `tar` instead of pulling in an npm tar library — | ||
| // keeps the script zero-dependency. | ||
| // | ||
| // GitHub tarballs always have exactly one top-level directory whose | ||
| // name encodes the repo + commit. We return that path so the caller | ||
| // knows where to find the extracted tree. | ||
| async function extractTarball(tarballPath, intoDir) { | ||
| await fs.mkdir(intoDir, { recursive: true }); | ||
| const result = spawnSync("tar", ["-xzf", tarballPath, "-C", intoDir], { stdio: "inherit" }); | ||
| if (result.status !== 0) throw new Error(`tar exited with status ${result.status}`); | ||
| const [topLevel] = await fs.readdir(intoDir); | ||
| return path.join(intoDir, topLevel); | ||
| } | ||
|
|
||
| // copy one path from the extracted tree into the plugin | ||
|
|
||
| // Removes the destination first so we never end up with stale leftovers | ||
| // from a previous sync, then creates the destination's parent directory then copies. | ||
| async function copyPath(fromDir, toDir, relativePath) { | ||
| const from = path.join(fromDir, relativePath); | ||
| const to = path.join(toDir, relativePath); | ||
| if (!(await fileExists(from))) { | ||
| throw new Error(`path missing in upstream tarball: ${relativePath}`); | ||
| } | ||
| await fs.rm(to, { recursive: true, force: true }); | ||
| await fs.mkdir(path.dirname(to), { recursive: true }); | ||
| await fs.cp(from, to, { recursive: true }); | ||
| console.log(` ${relativePath} -> ${path.relative(process.cwd(), to)}`); | ||
| } | ||
|
|
||
| // Sync this plugin: read sync-skills-vendor.json, download + extract + copy. | ||
| // | ||
| // Paths are resolved relative to the script itself rather than CWD, so | ||
| // the script works regardless of where it's invoked from. The repo root | ||
| // is two levels up from .github/scripts/. | ||
| async function main() { | ||
| const scriptDir = path.dirname(fileURLToPath(import.meta.url)); | ||
| const repoRoot = path.resolve(scriptDir, "..", ".."); | ||
| const vendorPath = path.join(scriptDir, "sync-skills-vendor.json"); | ||
| if (!(await fileExists(vendorPath))) { | ||
| throw new Error(`missing sync-skills-vendor.json at ${vendorPath}`); | ||
| } | ||
|
|
||
| const { repo, pin, paths } = await readJson(vendorPath); | ||
| if (!repo || !pin || !Array.isArray(paths) || paths.length === 0) { | ||
| throw new Error(`${vendorPath} must define 'repo', 'pin' and a non-empty 'paths' array`); | ||
| } | ||
|
|
||
| console.log(`--- ${repo} (ref: ${pin}) ---`); | ||
|
|
||
| const workDir = await fs.mkdtemp(path.join(tmpdir(), "sync-skills-")); | ||
| try { | ||
| // `slug` is just a unique filename for this tarball + extract dir. | ||
| const slug = `${repo.replace("/", "-")}-${pin.replace(/[^A-Za-z0-9._-]/g, "_")}`; | ||
| const tarball = path.join(workDir, `${slug}.tar.gz`); | ||
| await downloadTarball(repo, pin, tarball); | ||
| const extracted = await extractTarball(tarball, path.join(workDir, slug)); | ||
| for (const rel of paths) await copyPath(extracted, repoRoot, rel); | ||
| } finally { | ||
| await fs.rm(workDir, { recursive: true, force: true }); | ||
| } | ||
| console.log("done."); | ||
| } | ||
|
|
||
| await main(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Vendored skills | ||
|
|
||
| The skill packages under `skills/` are vendored from **[jfrog/jfrog-skills](https://github.com/jfrog/jfrog-skills)** and committed to `main`. | ||
|
|
||
| | | | | ||
| | --- | --- | | ||
| | **Repository** | https://github.com/jfrog/jfrog-skills | | ||
| | **Pinned release** | see `pin` in [`.github/scripts/sync-skills-vendor.json`](.github/scripts/sync-skills-vendor.json) | | ||
|
|
||
| Included directories: `jfrog/`, `jfrog-package-safety-and-download/` (as of the pinned release). | ||
|
|
||
| ## Refreshing | ||
|
|
||
| When the upstream repo publishes a new release, refresh the vendored tree via a PR that: | ||
|
|
||
| 1. Bumps `pin` in [`.github/scripts/sync-skills-vendor.json`](.github/scripts/sync-skills-vendor.json) to the new tag. | ||
| 2. Re-syncs and commits the refreshed `skills/` tree. | ||
| 3. Bumps `version` in [`.claude-plugin/plugin.json`](.claude-plugin/plugin.json) so users actually receive the update (Claude Code skips installs whose resolved version hasn't changed). | ||
|
|
||
| To regenerate the tree locally before opening the PR: | ||
|
|
||
| ```bash | ||
| node .github/scripts/sync-skills.mjs | ||
| ``` | ||
|
|
||
| The script reads its sibling [`sync-skills-vendor.json`](.github/scripts/sync-skills-vendor.json), downloads the pinned upstream tarball from `codeload.github.com`, and replaces the directories listed in `paths` (today: `skills/`). |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.