Skip to content

Add all repos if non given#285

Open
derhecht wants to merge 4 commits into
jfrog:masterfrom
derhecht:master
Open

Add all repos if non given#285
derhecht wants to merge 4 commits into
jfrog:masterfrom
derhecht:master

Conversation

@derhecht

Copy link
Copy Markdown

like cleanup script

same behavior as for cleanup script
Use all repositories if non given
@elioengcomp

Copy link
Copy Markdown
Contributor

Hi @derhecht , thank you for your contribution.

I'm not very comfortable with adding behavior when some configuration value is missing. I think It can hide configuration mistakes and provide an undesired result. This is specially important in cases like this where we are deleting things from the server.

I would like to suggest the usage of a key word, something like ALL, to be used by the user to set the repo/path list parameter when looking for the behavior added by you. We also need to document that as a possible configuration value in the README file.

@calvinpark

Copy link
Copy Markdown

Excellent change! Picked up for my RT

@derhecht

Copy link
Copy Markdown
Author

Hi @derhecht , thank you for your contribution.

I'm not very comfortable with adding behavior when some configuration value is missing. I think It can hide configuration mistakes and provide an undesired result. This is specially important in cases like this where we are deleting things from the server.

I would like to suggest the usage of a key word, something like ALL, to be used by the user to set the repo/path list parameter when looking for the behavior added by you. We also need to document that as a possible configuration value in the README file.

Hi @elioengcomp may have a look at this approach?

@CLAassistant

CLAassistant commented Jun 20, 2020

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@derhecht

Copy link
Copy Markdown
Author

ok, added email address to my account, signed CLA, recheck seems not to work...

@derhecht

Copy link
Copy Markdown
Author

got it. finally.

@yashprit-jfrog

Copy link
Copy Markdown
Contributor

@derhecht this PR is open for long time. Are you still open to take this PR to closer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants