Fix test runner : add JUnit Vintage Engine to run JUnit 4 tests on JUnit Platform - #23
Open
Darshan-dev57 wants to merge 2 commits into
Open
Fix test runner : add JUnit Vintage Engine to run JUnit 4 tests on JUnit Platform#23Darshan-dev57 wants to merge 2 commits into
Darshan-dev57 wants to merge 2 commits into
Conversation
…it Platform Tests use JUnit 4 annotations (org.junit.Test) but build.gradle only had JUnit 5 (Jupiter). Added junit-vintage-engine to run JUnit 4 tests on JUnit Platform. Result: 35 tests now execute (33 pass, 2 pre-existing failures unrelated to test runner - Java 11 module access issues in converter code).
Member
|
Thank you for your PR. |
Member
|
One unit test fails; we will have to look into how exactly it fails and what the root cause is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests use JUnit 4 annotations (org.junit.Test) but build.gradle only had JUnit 5 (Jupiter). Added junit-vintage-engine to run JUnit 4 tests on JUnit Platform.
Result: 35 tests now execute (33 pass, 2 pre-existing failures unrelated to test runner - Java 11 module access issues in converter code).