Allow classic jump list to scroll and fix div tag - #308
Open
Truffula wants to merge 4 commits into
Open
Conversation
Updated to match the fixed version from the parallel layout. Also discovered a `</div>` tag was missing. Fixes jashkenas#302.
In the output html files, any directory separators will be replaced with underscores (rather than replicating the folder structure, which would create unnecessary headaches with linking). Fixes jashkenas#309, fixes jashkenas#303. Also includes some previous changes that were in `docco.litcoffee` but hadn’t found their way into `docco.js`. Theoretically it would still create a naming conflict in cases where you had two files, `foo_bar.coffee` and `foo/index.coffee` which could be precluded with a double-underscore or similar, but I don’t think there’s a strong likelihood of that occurring.
Applied change from previous commit (re: jashkenas#309 and jashkenas#303) to the classic and linear templates. I’m not sure if some people have a preference for just showing the basename, but that option isn’t really compatible with multi-directory sites. For single-folder sites (say, if everything is in `app/`, and you don’t want `app/` at the front of all your links) you can get around it simply by running docco from within the folder containing the files (at least with the CLI).
Author
|
Now includes updates to output file paths (and links) for multi-directory sites. |
Makes all links accessible on large sites. Additional change for jashkenas#302.
Collaborator
|
Looks like a good change to me, but I'd like @jashkenas to take a look and do the merge |
Author
|
Hi @jashkenas, have you had a chance to have a look at this PR yet? |
Owner
|
I haven't. Got a screenshot? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to match the fixed version from the parallel layout. Also
discovered a
</div>tag was missing.Fixes #302.