Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streaming HTTP failures currently send the same request twice: the error branch calls data(for:) after bytes(for:) to obtain diagnostics. On Apple platforms, cancelling a stream consumer also leaves the URLSession request running, and AsyncBytes.lines removes the blank lines needed to delimit SSE events. The shared parser decodes each data: line separately and continues past [DONE].
This change reads the original error body for Responses, Chat Completions and Assistants, retaining the existing APIError.responseUnsuccessful status and message contract. The Apple adapter reuses HTTPLineDecoder and cancels only the producer and URLSessionTask belonging to that request. The Responses/Chat Completions parser joins data fields per event, ignores SSE control fields, and stops at [DONE]. Malformed payloads still fail; the existing final-line-at-EOF behavior is preserved.
Validation:
Related implementation history: #160 added the repeated error-body request; #6 added earlier stream cancellation support; #200 introduced the line decoder for Linux. This PR does not change the Linux adapter or the successful Assistants event parser. Validation uses synthetic responses and a loopback server, without API credentials or model calls.