chore: dependencies and coverage - #9
Conversation
Code reviewReviewed dependency bumps (NestJS 10→11, ESLint flat config, Jest 30, TS 5.9, AWS SDK v3), the new CI workflow/husky hooks/coverage thresholds, and the hand-written logic changes (MCP client capabilities, Lambda handler for Node 24, CDK runtime bump, new enum values). No CLAUDE.md violations or significant bugs found in most of the diff. Two issues below survived independent verification. 1. Lines 28 to 31 in 13ae1f7 The new agent instructions state:
Lines 28 to 31 in 13ae1f7 2. bubblyclouds-api/scripts/local-dynamodb-setup.ts Lines 11 to 13 in 13ae1f7 import 'dotenv/config';
🤖 Generated with Claude Code |
npm ci failed in CI (Linux) because @emnapi/core@1.11.3 and @emnapi/runtime@1.11.3 — optional peer deps of @napi-rs/wasm-runtime — were missing from the lock files. They were generated on macOS, where npm did not materialise these Linux-relevant entries. Regenerated both package-lock.json files in a node:24 Linux container so npm ci passes on both platforms. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RjaNPPmg3GwWBPGz6uFd6e
The deploy CDK test bundles the API Lambda from Code.fromAsset('../dist')
(deploy/lib/api-stack.ts:234), but the deploy job never built the root
app, so ../dist was missing and the test threw CannotFindAsset. This was
masked until now because npm ci failed earlier in the job. Install root
deps and run build:nest before the deploy build/test steps.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RjaNPPmg3GwWBPGz6uFd6e
@emnapi/core, @emnapi/runtime and @emnapi/wasi-threads are optional peer deps of @napi-rs/wasm-runtime that npm only materialises into the lock on Linux. A plain 'npm install' on macOS would strip the Linux-relevant top-level entries back out, breaking 'npm ci' in CI again. Declaring them as exact devDependencies in both packages makes 'npm install' keep them in package-lock.json on every platform. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RjaNPPmg3GwWBPGz6uFd6e
No description provided.