Conversation
This adds a new setting noMultiTouch and makes it the default. With `noMultiTouch` set to true snap.js won't react to multi finger gestures. This should be the default as it's quite unlikely to be what the user expects. It helps to prevent issues with other gestures like pinch zooming.
Collaborator
|
I would say that Snap.js shouldn't make this an option, it just need to be the native behavior. The gesture we are going for is a single finger swipe to the left or right, no? So if that's the gesture that is supported, we need to stick with that. If we allow a multi-finger swipe, then we need to account for that. I just don't see this as something that should get turned on/off. |
Author
|
That's why I made it the default because I agree that a single finger swipe is what we aim for. I made it an option because I didn't know if people may rely on multi-touch swipes as that's the current behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new setting noMultiTouch and makes it the default.
With
noMultiTouchset to true snap.js won't react to multifinger gestures. This should be the default as it's quite unlikely
to be what the user expects. It helps to prevent issues
with other gestures like pinch zooming.