[pull] dev from KelvinTegelaar:dev#91
Open
pull[bot] wants to merge 104 commits into
Open
Conversation
Update to go with CVE Management extension and NinjaOne CVE sync
Oops - forgot to add the new pages to the index here Signed-off-by: DamienMatthys <damien@pcunplug.com>
Dev to hotfix
Dev to hotfix
### What
Tenant dropdowns can show the previous tenant's data for a few minutes after switching tenants. Easiest place to see it: Intune > Device Management > Devices, open the Change Primary User action on a device and load the user dropdown, then switch tenant on the same page and open it again. The dropdown still lists the first tenant's users.
### Why
`CippAutocomplete` injects `tenantFilter: currentTenant` into the request, but `ApiGetCallWithPagination` builds the React Query cache key from `queryKey` only:
```js
// src/api/ApiCall.jsx
queryKey: [queryKey],
...
staleTime: 300000,
refetchOnWindowFocus: false,
```
Several dropdowns pass a fixed string for that key, so the same cache entry is reused across tenants. Nothing invalidates it when the tenant changes, and with a 5 minute `staleTime` you get the previous tenant's list back.
The clearest case is the shared `"ListUsersAutoComplete"` key, used on:
- Intune > Device Management > Devices and the device detail page (Change Primary User)
- SharePoint site members (add and remove)
- OneDrive
`"AdministrativeUnits"` in the audit log search drawer has the same problem.
### Fix
Scope the key to the tenant whenever the tenant filter is injected, in the one place the request is assembled:
```js
const tenantScoped = !currentApi.excludeTenantFilter
...
queryKey:
tenantScoped && currentApi.queryKey
? `${currentApi.queryKey}-${currentTenant}`
: currentApi.queryKey,
```
Dropdowns that set `excludeTenantFilter` (global data) keep their existing key and are not affected. I also checked that nothing invalidates these keys by exact string match, so this does not break any refresh after a mutation.
### How to test
1. Go to Intune > Device Management > Devices on a tenant.
2. Open the three dots actions menu on a device, choose Change Primary User, and let the user dropdown load.
3. Cancel the dialog.
4. Switch tenant from the selector on the same page, open the actions menu again, and choose Change Primary User.
Before this change the dropdown loads the previous tenant's user list. After, it loads the correct tenant's users.
The same caching issue affects the SharePoint and OneDrive member pickers and the Administrative Units filter in the audit log search drawer.
Signed-off-by: Callum Taylor <88286655+CTaylor-1@users.noreply.github.com>
Bumps [date-fns](https://github.com/date-fns/date-fns) from 4.1.0 to 4.4.0. - [Release notes](https://github.com/date-fns/date-fns/releases) - [Commits](date-fns/date-fns@v4.1.0...v4.4.0) --- updated-dependencies: - dependency-name: date-fns dependency-version: 4.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [react-error-boundary](https://github.com/bvaughn/react-error-boundary) from 6.1.1 to 6.1.2. - [Release notes](https://github.com/bvaughn/react-error-boundary/releases) - [Commits](bvaughn/react-error-boundary@6.1.1...6.1.2) --- updated-dependencies: - dependency-name: react-error-boundary dependency-version: 6.1.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [jspdf-autotable](https://github.com/simonbengtsson/jsPDF-AutoTable) from 5.0.7 to 5.0.8. - [Release notes](https://github.com/simonbengtsson/jsPDF-AutoTable/releases) - [Commits](simonbengtsson/jsPDF-AutoTable@v5.0.7...v5.0.8) --- updated-dependencies: - dependency-name: jspdf-autotable dependency-version: 5.0.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [next](https://github.com/vercel/next.js) from 16.2.2 to 16.2.9. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v16.2.2...v16.2.9) --- updated-dependencies: - dependency-name: next dependency-version: 16.2.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@tanstack/react-query](https://github.com/TanStack/query/tree/HEAD/packages/react-query) from 5.100.10 to 5.101.0. - [Release notes](https://github.com/TanStack/query/releases) - [Changelog](https://github.com/TanStack/query/blob/main/packages/react-query/CHANGELOG.md) - [Commits](https://github.com/TanStack/query/commits/@tanstack/react-query@5.101.0/packages/react-query) --- updated-dependencies: - dependency-name: "@tanstack/react-query" dependency-version: 5.101.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…rings Clarify all deviations strings
fixes the crash in the secure score table overview page, if it was switched to before the data was finished loading
Fix: Fix unnecessary re-renders and crash in secure score table overview
Fix Sign-in report export showing "No data" for Location (and other object columns)
…egration feat(BEC): add sent messages check and update checks numbering
Feat: Enhance Intune group assignment functionality with excludes
…dev/date-fns-4.4.0 chore(deps): bump date-fns from 4.1.0 to 4.4.0
…dev/react-error-boundary-6.1.2 chore(deps): bump react-error-boundary from 6.1.1 to 6.1.2
…dev/jspdf-autotable-5.0.8 chore(deps): bump jspdf-autotable from 5.0.7 to 5.0.8
…dev/next-16.2.9 chore(deps): bump next from 16.2.2 to 16.2.9
…dev/tanstack/react-query-5.101.0 chore(deps): bump @tanstack/react-query from 5.100.10 to 5.101.0
Feat: Add severity action to incidents list
Feat: Add allTenants support for shared mailbox enabled report
fix: scope CippAutocomplete query keys to the active tenant
Feat: Add navigation links to cards for better UX
Signed-off-by: KelvinTegelaar <49186168+KelvinTegelaar@users.noreply.github.com>
CVE Management Extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )