Disallow : as the first character of metadata keys - #567
Closed
progval wants to merge 2 commits into
Closed
Conversation
It can't be serialized as a non-trailing parameter, eg. in 'METADATA <Target> <Key> <Visibility> <Value>'
emersion
approved these changes
Jun 21, 2025
Member
|
Do we maybe want to disallow |
Contributor
Author
|
sure, why not |
slingamn
approved these changes
Jun 22, 2025
slingamn
left a comment
slingamn
left a comment
Contributor
There was a problem hiding this comment.
Credit for finding this goes to @thatcher-gaming
slingamn
added a commit
to slingamn/ircv3-specifications
that referenced
this pull request
Jun 22, 2025
* Disallow colon entirely as in ircv3#567 * Disallow A-Z * Remove requirement of case-insensitive handling
ValwareIRC
approved these changes
Oct 18, 2025
Member
|
This was already merged in #566 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can't be serialized as a non-trailing parameter, eg. in 'METADATA '
Found by @slingamn